Re: [PATCH] Fix memory leak from used_server_addr during deinit

2021-01-09 Thread Willy Tarreau
Hi, patch applied now, thanks! On Sat, Jan 09, 2021 at 03:24:36PM -0700, Thayne McCombs wrote: > > I'm just wondering if it technically would be necessary to remove the > server from the tree or not? > > I don't think so. But I'm not sure. I don't think it's strictly necessary, however I really

Re: [PATCH] Fix memory leak from used_server_addr during deinit

2021-01-09 Thread Thayne McCombs
> I'm just wondering if it technically would be necessary to remove the server from the tree or not? I don't think so. But I'm not sure. On Sat, Jan 9, 2021, 06:34 Tim Düsterhus wrote: > Thayne, > > Am 09.01.21 um 08:45 schrieb Thayne McCombs: > > > > After actually reading the full CONTRIBUTIN

Re: [PATCH] Fix memory leak from used_server_addr during deinit

2021-01-09 Thread Tim Düsterhus
Thayne, Am 09.01.21 um 08:45 schrieb Thayne McCombs: > > After actually reading the full CONTRIBUTING file, I now include my patch > with a better commit message. Sorry about that. > Thanks, the commit message looks good to me and I can confirm your patch fixes the issue I was seeing. I'm jus

Re: [PATCH] Fix memory leak from used_server_addr during deinit

2021-01-08 Thread Thayne McCombs
After actually reading the full CONTRIBUTING file, I now include my patch with a better commit message. Sorry about that. >From b449379a7b36c213408b1ae28924475c413bd6ba Mon Sep 17 00:00:00 2001 From: Thayne McCombs Date: Thu, 7 Jan 2021 22:11:05 -0700 Subject: [PATCH] BUG/MINOR: server: Memory l

[PATCH] Fix memory leak from used_server_addr during deinit

2021-01-07 Thread Thayne McCombs
Fixes #1037 --- src/haproxy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/haproxy.c b/src/haproxy.c index a28b45fb9..1d16b507d 100644 --- a/src/haproxy.c +++ b/src/haproxy.c @@ -2649,6 +2649,7 @@ void deinit(void) free(s->available_conns);