Re: [PATCH] MINOR: startup: certain goto paths in init_pollers fail to free

2019-01-21 Thread Uman Shahzad
Hi On Mon, Jan 21, 2019, at 08:49, Willy Tarreau wrote: > On Mon, Jan 21, 2019 at 04:39:53AM +0100, Willy Tarreau wrote: > > Hi, > > > > On Thu, Jan 17, 2019 at 08:21:39AM +, Uman Shahzad wrote: > > > If we fail to initialize pollers due to fdtab/fdinfo/polled_mask > > > not getting allocated

Re: [PATCH] MINOR: startup: certain goto paths in init_pollers fail to free

2019-01-20 Thread Willy Tarreau
On Mon, Jan 21, 2019 at 04:39:53AM +0100, Willy Tarreau wrote: > Hi, > > On Thu, Jan 17, 2019 at 08:21:39AM +, Uman Shahzad wrote: > > If we fail to initialize pollers due to fdtab/fdinfo/polled_mask > > not getting allocated, we free any of those that were allocated > > and exit. However the

Re: [PATCH] MINOR: startup: certain goto paths in init_pollers fail to free

2019-01-20 Thread Willy Tarreau
Hi, On Thu, Jan 17, 2019 at 08:21:39AM +, Uman Shahzad wrote: > If we fail to initialize pollers due to fdtab/fdinfo/polled_mask > not getting allocated, we free any of those that were allocated > and exit. However the ordering was incorrect, and there was an old > unused and unreachable "fail

Re: [PATCH] MINOR: startup: certain goto paths in init_pollers fail to free

2019-01-20 Thread Uman Shahzad
Hi, can someone check this one out? Is there something wrong with it? On Thu, Jan 17, 2019, at 13:21, Uman Shahzad wrote: > If we fail to initialize pollers due to fdtab/fdinfo/polled_mask > not getting allocated, we free any of those that were allocated > and exit. However the ordering was incorr

[PATCH] MINOR: startup: certain goto paths in init_pollers fail to free

2019-01-17 Thread Uman Shahzad
If we fail to initialize pollers due to fdtab/fdinfo/polled_mask not getting allocated, we free any of those that were allocated and exit. However the ordering was incorrect, and there was an old unused and unreachable "fail_cache" path as well. --- src/fd.c | 7 ++- 1 file changed, 2 insertio