Re: [PATCH] MINOR?: stconn/connection: Fix suspect change causing timeouts

2024-06-10 Thread William Manley
On Mon, Jun 10, 2024, at 3:29 PM, Christopher Faulet wrote: > Le 05/06/2024 à 22:55, William Manley a écrit : > > This fixes an issue I've had where if a connection was idle for ~23s > > it would get in a bad state. I don't understand this code, so I'm > > not sure exactly why it was failing. > >

Re: [PATCH] MINOR?: stconn/connection: Fix suspect change causing timeouts

2024-06-10 Thread Christopher Faulet
Le 05/06/2024 à 22:55, William Manley a écrit : This fixes an issue I've had where if a connection was idle for ~23s it would get in a bad state. I don't understand this code, so I'm not sure exactly why it was failing. I discovered this by bisecting to identify the commit that caused the regre

[PATCH] MINOR?: stconn/connection: Fix suspect change causing timeouts

2024-06-05 Thread William Manley
This fixes an issue I've had where if a connection was idle for ~23s it would get in a bad state. I don't understand this code, so I'm not sure exactly why it was failing. I discovered this by bisecting to identify the commit that caused the regression between 2.9 and 3.0. The commit is d2c3f8dd