Hi Christopher, This is a new series which follows the work done on frontend side.
It starts with two minor patches which are more comestic; then it addresses backend and servers. I made sure to not reproduce the same mistake for the default case you just fixed on frontends. There is probably a few controversial points where I did not know how we could handle prior calculation when it is needed for several fields. So I ended up putting them in a condition testing fields where it is needed. It is a bit ugly I admit but I'm open for suggestions. After this patch series, I have a few other things in queue: - an attempt to better reuse already existing description on stats.c - first attempt to adapt labels with state and health check but I prefer merging things along the way to avoid huge reviews. William Dauchy (6): MINOR: contrib/prometheus-exporter: better output of Not-a-Number CLEANUP: stats: improve field selection for frontend http fields MEDIUM: stats: allow to select one field in `stats_fill_be_stats` MINOR: contrib/prometheus-exporter: use fill_be_stats for backend dump MEDIUM: stats: allow to select one field in `stats_fill_sv_stats` MINOR: contrib/prometheus-exporter: use fill_sv_stats for server dump .../prometheus-exporter/service-prometheus.c | 314 +----- include/haproxy/stats.h | 7 +- src/hlua_fcn.c | 5 +- src/stats.c | 987 +++++++++++------- 4 files changed, 670 insertions(+), 643 deletions(-) -- 2.29.2
