[PATCH 1/1: BUILD/MINOR: TCP_KEEPIDLE macos equivalence

2022-05-01 Thread David CARLIER
Hi here a little patch to set idle time for SO_KEEPALIVE socket option. Kind regards. 0001-BUILD-MINOR-socket-translate-TCP_KEEPIDLE-for-macOs-.patch Description: Binary data

Re: [PATCH 1/1: BUILD/MINOR: TCP_KEEPIDLE macos equivalence

2022-05-08 Thread Willy Tarreau
On Sun, May 01, 2022 at 03:33:17PM +0100, David CARLIER wrote: > Hi here a little patch to set idle time for SO_KEEPALIVE socket option. Now merged, thanks. David, one comment though, your commit messages keep missing a lot of crucial information for reviewers and debuggers, and I had to spend ti

Re: [PATCH 1/1: BUILD/MINOR: TCP_KEEPIDLE macos equivalence

2022-05-08 Thread David CARLIER
On Sun, 8 May 2022 at 09:57, Willy Tarreau wrote: > > On Sun, May 01, 2022 at 03:33:17PM +0100, David CARLIER wrote: > > Hi here a little patch to set idle time for SO_KEEPALIVE socket option. > > Now merged, thanks. > > David, one comment though, your commit messages keep missing a lot of > cruci

Re: [PATCH 1/1: BUILD/MINOR: TCP_KEEPIDLE macos equivalence

2022-05-08 Thread Willy Tarreau
On Sun, May 08, 2022 at 10:21:28AM +0100, David CARLIER wrote: > On Sun, 8 May 2022 at 09:57, Willy Tarreau wrote: > > > > On Sun, May 01, 2022 at 03:33:17PM +0100, David CARLIER wrote: > > > Hi here a little patch to set idle time for SO_KEEPALIVE socket option. > > > > Now merged, thanks. > > >

Re: [PATCH 1/1: BUILD/MINOR: TCP_KEEPIDLE macos equivalence

2022-05-08 Thread Vincent Bernat
❦ 8 May 2022 10:57 +02, Willy Tarreau: > After edition (still minimal and possibly inaccurate but the best I > could do): > > On Linux the interval before starting to send TCP keep-alive packets > is defined by TCP_KEEPIDLE. MacOS has an equivalent with TCP_KEEPIDLE, > which also

Re: [PATCH 1/1: BUILD/MINOR: TCP_KEEPIDLE macos equivalence

2022-05-08 Thread Willy Tarreau
On Sun, May 08, 2022 at 12:39:13PM +0200, Vincent Bernat wrote: > ? 8 May 2022 10:57 +02, Willy Tarreau: > > > After edition (still minimal and possibly inaccurate but the best I > > could do): > > > > On Linux the interval before starting to send TCP keep-alive packets > > is define