Re: [PATCH 1/2] BUG/MINOR: tools: Leave parse_line after exceeding argsmax

2020-06-23 Thread Willy Tarreau
Hi Tim, On Tue, Jun 23, 2020 at 05:06:27PM +0200, Tim Duesterhus wrote: > Otherwise `arg++` will be executed for every argument after the maximum, > returning a bogus value. No, it returns the correct one, as documented at the beginning of the function: ... are not updated beyond but the

[PATCH 1/2] BUG/MINOR: tools: Leave parse_line after exceeding argsmax

2020-06-23 Thread Tim Duesterhus
Otherwise `arg++` will be executed for every argument after the maximum, returning a bogus value. Consider a configuration like this: listen foo 1 2 3 [...] 64 65 Then running a configuration check within valgrind reports the following: ==18265== Conditional jump or move depends