Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-13 Thread Patrick Hemmer
On 2018/8/13 09:17, Aleksandar Lazic wrote: > On 11/08/2018 14:48, Patrick Hemmer wrote: >> > > [snipp] > >> To answer one of the earlier questions, I do plan on writing a blog >> article yes. The question is when. I'm considering backporting this >> feature to 1.8 for my own use at work, and if

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-13 Thread Aleksandar Lazic
On 11/08/2018 14:48, Patrick Hemmer wrote: [snipp] To answer one of the earlier questions, I do plan on writing a blog article yes. The question is when. I'm considering backporting this feature to 1.8 for my own use at work, and if done, might wait for that so I have some real world usage t

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Willy Tarreau
On Sat, Aug 11, 2018 at 02:48:27PM -0400, Patrick Hemmer wrote: > Actually it does take a sample expression, not a constant. This was done > so that you could calculate a priority based on multiple criteria in the > request. Oh that's perfect then, I didn't even notice when reviewing the patches.

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Patrick Hemmer
On 2018/8/11 11:25, Aleksandar Lazic wrote: > Hi Willy. > > > On 11/08/2018 11:04, Willy Tarreau wrote: >> Hi Aleks, >> >> On Sat, Aug 11, 2018 at 10:27:42AM +0200, Aleksandar Lazic wrote: >>> I think it is a requeue mechanism for the connection and not a >>> selector for >>> a server or a backen

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Aleksandar Lazic
Hi Willy. On 11/08/2018 11:04, Willy Tarreau wrote: Hi Aleks, On Sat, Aug 11, 2018 at 10:27:42AM +0200, Aleksandar Lazic wrote: I think it is a requeue mechanism for the connection and not a selector for a server or a backend, but I can be wrong. That's it. I'll try to explain shortly. You'

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Willy Tarreau
Hi Aleks, On Sat, Aug 11, 2018 at 10:27:42AM +0200, Aleksandar Lazic wrote: > I think it is a requeue mechanism for the connection and not a selector for > a server or a backend, but I can be wrong. That's it. I'll try to explain shortly. You're probably aware how the queuing mechanism works in h

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Aleksandar Lazic
Hi. Am 10-08-2018 17:12, schrieb Willy Tarreau: On Fri, Aug 10, 2018 at 09:54:38AM -0400, Patrick Hemmer wrote: Merge it! Now done! Quite happy to see this done with. Any issues can be addressed as bug fixes. Yes, same here. I've updated the ROADMAP file to remove this 8-years old entry :

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-10 Thread Willy Tarreau
On Fri, Aug 10, 2018 at 09:54:38AM -0400, Patrick Hemmer wrote: > Merge it! Now done! > Quite happy to see this done with. Any issues can be addressed as bug fixes. Yes, same here. I've updated the ROADMAP file to remove this 8-years old entry :-) Thanks! Willy

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-10 Thread Patrick Hemmer
On 2018/8/10 09:19, Willy Tarreau wrote: > Hi Patrick, > > On Thu, Aug 09, 2018 at 06:29:33PM -0400, Patrick Hemmer wrote: >> I also went and removed the queue position counter code from >> stream_process_counters(), and the logging still appears to work fine >> (but I could have easily missed so

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-10 Thread Willy Tarreau
Hi Patrick, On Thu, Aug 09, 2018 at 06:29:33PM -0400, Patrick Hemmer wrote: > I also went and removed the queue position counter code from > stream_process_counters(), and the logging still appears to work fine > (but I could have easily missed some potential scenarios). OK nice! > In regards to

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-09 Thread Patrick Hemmer
Re-adding the mailing list. On 2018/8/6 22:37, Willy Tarreau wrote: > Hi Patrick, >>> I *think* that the change made to stream_process_counters() is not needed, >>> because stream_process_counters() is normally used to keep the stats up >>> to date so that when refreshing the stats page they don't

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-06-06 Thread Patrick Hemmer
On 2018/5/31 00:57, Willy Tarreau wrote: > Hi Patrick, > > On Thu, May 31, 2018 at 12:16:27AM -0400, Patrick Hemmer wrote: >>> I looked at the code to see if something could cause that. I found that the >>> key increment could be a reason (you must restart from the next element, >>> not an upper

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-30 Thread Willy Tarreau
Hi Patrick, On Thu, May 31, 2018 at 12:16:27AM -0400, Patrick Hemmer wrote: > > I looked at the code to see if something could cause that. I found that the > > key increment could be a reason (you must restart from the next element, > > not an upper value since there will be many duplicate keys)

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-30 Thread Patrick Hemmer
On 2018/5/30 04:00, Willy Tarreau wrote: > Hi Patrick, > > I'm finally back on this. > > On Mon, May 14, 2018 at 01:05:03AM -0400, Patrick Hemmer wrote: >> On 2018/5/11 12:52, Patrick Hemmer wrote: >>> This adds the set-priority-class and set-priority-offset actions to >>> http-request and tcp-re

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-30 Thread Willy Tarreau
On Wed, May 30, 2018 at 10:00:24AM +0200, Willy Tarreau wrote: > I noticed a strange effect which is that when injecting under low load with > a higher priority (either offset or class) than another high level traffic, > the response time on the higher priority traffic follows a sawtooth shape, > i

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-30 Thread Willy Tarreau
Hi Patrick, I'm finally back on this. On Mon, May 14, 2018 at 01:05:03AM -0400, Patrick Hemmer wrote: > On 2018/5/11 12:52, Patrick Hemmer wrote: > > This adds the set-priority-class and set-priority-offset actions to > > http-request and tcp-request content. > > The priority values are used when

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-13 Thread Patrick Hemmer
On 2018/5/11 12:52, Patrick Hemmer wrote: > This adds the set-priority-class and set-priority-offset actions to > http-request and tcp-request content. > The priority values are used when connections are queued to determine > which connections should be served first. The lowest priority class is

[PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-11 Thread Patrick Hemmer
This adds the set-priority-class and set-priority-offset actions to http-request and tcp-request content. The priority values are used when connections are queued to determine which connections should be served first. The lowest priority class is served first. When multiple requests from the same

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-10 Thread Patrick Hemmer
On 2018/5/10 01:35, Patrick Hemmer wrote: > This adds the set-priority-class and set-priority-offset actions to > http-request and tcp-request content. > The priority values are used when connections are queued to determine > which connections should be served first. The lowest priority class is

[PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-05-09 Thread Patrick Hemmer
This adds the set-priority-class and set-priority-offset actions to http-request and tcp-request content. The priority values are used when connections are queued to determine which connections should be served first. The lowest priority class is served first. When multiple requests from the same