Re: [PATCH 1/9] MAJOR: contrib/prometheus-exporter: move health check status to labels

2021-02-01 Thread William Dauchy
On Mon, Feb 1, 2021 at 12:05 PM Pierre Cheynier wrote: > In addition to this update, I would add some recommendations about the user > setup in the README ("how do I prevent my prometheus instance to explode > when scrapping this endpoint?"). > For server-template users: > - > params: >

RE: [PATCH 1/9] MAJOR: contrib/prometheus-exporter: move health check status to labels

2021-02-01 Thread Pierre Cheynier
De : William Dauchy Envoyé : samedi 30 janvier 2021 16:21 > this is a follow up of commit c6464591a365bfcf509b322bdaa4d608c9395d75 > ("MAJOR: contrib/prometheus-exporter: move ftd/bkd/srv states to > labels"). The main goal being to be better aligned with prometheus use > cases in terms of

[PATCH 1/9] MAJOR: contrib/prometheus-exporter: move health check status to labels

2021-01-30 Thread William Dauchy
this patch is a breaking change between v2.3 and v2.4: we move from using gauge value for health check states to labels values. The diff is quite small thanks to the preparation work from Christopher to allow more flexibility in labels, see commit 5a2f938732126f43bbf4cea5482c01552b0d0314 ("MEDIUM: