Re: [PATCH 3/3] MEDIUM: proxy_protocol: Support sending unique IDs using PPv2

2020-03-13 Thread Tim Düsterhus
Willy, Ilya, Am 13.03.20 um 12:06 schrieb Willy Tarreau: >> I just realized that BUG_ON is not active by default (should we add >> DEBUG_STRICT=1 to CI?). The check in there does not even compile (facepalm). > > Yes, definitely a good idea. I've filed an issue for the CI expert Ilya to look into

Re: [PATCH 3/3] MEDIUM: proxy_protocol: Support sending unique IDs using PPv2

2020-03-13 Thread Willy Tarreau
On Fri, Mar 06, 2020 at 01:15:40PM +0100, Tim Duesterhus wrote: > @@ -1466,6 +1466,20 @@ int make_proxy_line_v2(char *buf, int buf_len, struct > server *srv, struct connec > ret += make_tlv(&buf[ret], (buf_len - ret), > PP2_TYPE_AUTHORITY, value_len, value); >

Re: [PATCH 3/3] MEDIUM: proxy_protocol: Support sending unique IDs using PPv2

2020-03-13 Thread Willy Tarreau
On Mon, Mar 09, 2020 at 05:07:38PM +0100, Tim Düsterhus wrote: > Willy, > > Am 06.03.20 um 13:15 schrieb Tim Duesterhus: > > is acceptable. There's also a `BUG_ON` left in the patch, because I wasn't > > sure if I should grab the session from the stream or from the connection. > > I just realized

Re: [PATCH 3/3] MEDIUM: proxy_protocol: Support sending unique IDs using PPv2

2020-03-09 Thread Tim Düsterhus
Willy, Am 06.03.20 um 13:15 schrieb Tim Duesterhus: > is acceptable. There's also a `BUG_ON` left in the patch, because I wasn't > sure if I should grab the session from the stream or from the connection. I just realized that BUG_ON is not active by default (should we add DEBUG_STRICT=1 to CI?).

[PATCH 3/3] MEDIUM: proxy_protocol: Support sending unique IDs using PPv2

2020-03-06 Thread Tim Duesterhus
Willy, this patch adds the sending of generated unique IDs using PROXYv2. I'm not sure whether the way I made the stream available in the proxy line sending is acceptable. There's also a `BUG_ON` left in the patch, because I wasn't sure if I should grab the session from the stream or from the conn