Re: [PATCH 5/6] MEDIUM: stats: allow to select one field in `stats_fill_sv_stats`

2021-01-25 Thread William Dauchy
Hello Christopher, Thanks for the review. On Mon, Jan 25, 2021 at 4:33 PM Christopher Faulet wrote: > The "via" parameter is unused. No reason to pass it. good catch. surprised gcc did not triggered it fixed in v2 > Same comment than for stats_fill_b_stats. The metric variable must be > initi

Re: [PATCH 5/6] MEDIUM: stats: allow to select one field in `stats_fill_sv_stats`

2021-01-25 Thread Christopher Faulet
Le 22/01/2021 à 21:09, William Dauchy a écrit : prometheus approach requires to output all values for a given metric name; meaning we iterate through all metrics, and then iterate in the inner loop on all objects for this metric. In order to allow more code reuse, adapt the stats API to be able t

[PATCH 5/6] MEDIUM: stats: allow to select one field in `stats_fill_sv_stats`

2021-01-22 Thread William Dauchy
prometheus approach requires to output all values for a given metric name; meaning we iterate through all metrics, and then iterate in the inner loop on all objects for this metric. In order to allow more code reuse, adapt the stats API to be able to select one field or fill them all otherwise. Thi