Re: [PR] Add srvkey option to stick-table

Awesome! Thanks everyone. Thayne McCombs Senior Software Engineer tha...@lucidchart.com Lucid.co On Thu, Dec 31, 2020 at 2:10 AM Willy Tarreau wrote: > On Tue, Dec 29, 2020 at 10:52:56AM +0100, Frederic Lecaille wrote: > > > +#REQUIRE_VERSION=2.0 >

Re: [PR] Add srvkey option to stick-table

On Tue, Dec 29, 2020 at 10:52:56AM +0100, Frederic Lecaille wrote: > > +#REQUIRE_VERSION=2.0 > > Ok for this test but I think we should use 2.4 which is the current > developemnt version. OK I applied this change. Tested here and it works. > Willy, I think we can import this patch after having m

Re: [PR] Add srvkey option to stick-table

Hi guys, On Tue, Dec 29, 2020 at 10:45:17AM +0100, Frederic Lecaille wrote: > You work sounds perfect to me. FWIW I agree that th patch looks particularly clean. I've not studied it though, I trust you :-) > I am not sure we will import the second patch for the reg test: it makes > usage of curl

Re: [PR] Add srvkey option to stick-table

> I am not sure we will import the second patch for the reg test: it makes usage of curl. We try to not use external programs for reg tests except if there is no choice. Fine by me. I actually meant to say that my second attempt at writing a reg attempt should replace that patch. Apparently I forg

Re: [PR] Add srvkey option to stick-table

On 12/19/20 9:07 AM, Thayne McCombs wrote: From 731d6a00f3cf0c70d7a8a916e1984c225f3a9dd6 Mon Sep 17 00:00:00 2001 From: Thayne McCombs Date: Sat, 19 Dec 2020 00:59:35 -0700 Subject: [PATCH] Add test for stickiness using the server address for the  server key ---  reg-tests/stickiness/srvkey-

Re: [PR] Add srvkey option to stick-table

On 12/16/20 8:39 AM, Thayne McCombs wrote: On 12/10/20 1:31 AM, Frederic Lecaille wrote: It would be preferable to send all your patches, so that others than me may review your work (no diff between different versions of patches) and continue to split your work in several patches. Ok, here is

Re: [PR] Add srvkey option to stick-table

On 12/10/20 1:36 AM, Frederic Lecaille wrote: About a possible reg test, I remember there exists already one to test the stickiness. Have a look to reg-tests/stickiness/lb-services.vtc. I think it should be preferable to make a new reg test which would be a copy of this latter but with the "serv

Re: [PR] Add srvkey option to stick-table

On 12/10/20 1:31 AM, Frederic Lecaille wrote: > > It would be preferable to send all your patches, so that others than me > may review your work (no diff between different versions of patches) and > continue to split your work in several patches. > Ok, here is what I have so far as two patches

Re: [PR] Add srvkey option to stick-table

On 12/10/20 8:20 AM, Thayne McCombs wrote: Here are my updates from the feedback. It took me quite a while to figure out how to send this diff properly formatted with gmail. If you would like a single patch with all my changes, I can send that as well. About a possible reg test, I remember t

Re: [PR] Add srvkey option to stick-table

On 12/10/20 8:20 AM, Thayne McCombs wrote: Here are my updates from the feedback. It took me quite a while to figure out how to send this diff properly formatted with gmail. Thank you for your effort. The result is perfect. If you would like a single patch with all my changes, I can send th

Re: [PR] Add srvkey option to stick-table

Here are my updates from the feedback. It took me quite a while to figure out how to send this diff properly formatted with gmail. If you would like a single patch with all my changes, I can send that as well. >From 9c71b643e993dcafca36feae71cdfacc24ffaaa2 Mon Sep 17 00:00:00 2001 From: Thayne

Re: [PR] Add srvkey option to stick-table

On 12/2/20 8:48 AM, Thayne McCombs wrote: Thanks for your feedback. I have some followup questions. I think you should initialized this ebtree with EB_ROOT_UNIQUE as value. I'm not sure I understand what the distinction between EB_ROOT and EB_ROOT_UNIQUE is. I'm happy to add this, but I'd lik

Re: [PR] Add srvkey option to stick-table

Thanks for your feedback. I have some followup questions. > I think you should initialized this ebtree with EB_ROOT_UNIQUE as value. I'm not sure I understand what the distinction between EB_ROOT and EB_ROOT_UNIQUE is. I'm happy to add this, but I'd like to understand why it should be EB_ROOT_UNI

Re: [PR] Add srvkey option to stick-table

On 12/1/20 11:50 AM, Emeric Brun wrote: Hi, Hi Thayne, See my answers below. On 11/30/20 10:23 AM, PR Bot wrote: Dear list! Author: Thayne McCombs Number of patches: 2 This is an automated relay of the Github pull request: Add srvkey option to stick-table Patch title(s): Add srv

Re: [PR] Add srvkey option to stick-table

Hi, On 11/30/20 10:23 AM, PR Bot wrote: > Dear list! > > Author: Thayne McCombs > Number of patches: 2 > > This is an automated relay of the Github pull request: >Add srvkey option to stick-table > > Patch title(s): >Add srvkey option to stick-table >Harden sa2str agains 107-byte-l

[PR] Add srvkey option to stick-table

Dear list! Author: Thayne McCombs Number of patches: 2 This is an automated relay of the Github pull request: Add srvkey option to stick-table Patch title(s): Add srvkey option to stick-table Harden sa2str agains 107-byte-long abstract unix domain path Link: https://github.com/hap