Re: Minor - patch 1.6.x - Fix some warnings in Connection.c

2016-05-26 Thread Jonathan Fisher
Omg haha I'm an oaf. Thanks! I'm surprised that also didn't cause another warning. On May 26, 2016 12:19 AM, "Willy Tarreau" wrote: > Hi Jonathan, > > On Tue, May 24, 2016 at 05:04:16AM -0500, Jonathan Fisher wrote: > > What's the style you prefer? > > This one without the double negation :-) > >

Re: Minor - patch 1.6.x - Fix some warnings in Connection.c

2016-05-25 Thread Willy Tarreau
Hi Jonathan, On Tue, May 24, 2016 at 05:04:16AM -0500, Jonathan Fisher wrote: > What's the style you prefer? This one without the double negation :-) - if (!memcmp(line, "TCP4 ", 5) != 0) { + if (memcmp(line, "TCP4 ", 5) == 0) { I've just backported it now. Cheers, Willy

Re: Minor - patch 1.6.x - Fix some warnings in Connection.c

2016-05-24 Thread Jonathan Fisher
What's the style you prefer? On May 24, 2016 1:10 AM, "Willy Tarreau" wrote: > Hi Jonathan, > > On Fri, May 20, 2016 at 01:14:31PM -0400, Jonathan Fisher wrote: > > These warnings bother me. > > > > > > > > -- > > *Jonathan S. Fisher* > > Senior Software Engineer > > https://twitter.com/exabrial

Re: Minor - patch 1.6.x - Fix some warnings in Connection.c

2016-05-23 Thread Willy Tarreau
Hi Jonathan, On Fri, May 20, 2016 at 01:14:31PM -0400, Jonathan Fisher wrote: > These warnings bother me. > > > > -- > *Jonathan S. Fisher* > Senior Software Engineer > https://twitter.com/exabrial > http://www.tomitribe.com > https://www.tomitribe.io > diff --git a/src/connection.c b/src/con

Minor - patch 1.6.x - Fix some warnings in Connection.c

2016-05-20 Thread Jonathan Fisher
These warnings bother me. -- *Jonathan S. Fisher* Senior Software Engineer https://twitter.com/exabrial http://www.tomitribe.com https://www.tomitribe.io diff --git a/src/connection.c b/src/connection.c index 991cae3..12cdef0 100644 --- a/src/connection.c +++ b/src/connection.c @@ -385,7 +385,7