Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread Willy Tarreau
On Fri, Jan 26, 2024 at 06:35:09PM +, David Carlier wrote: > > > > It broke the CI on the "all features" build: > > > > > > https://github.com/haproxy/haproxy/actions/runs/7671640626/job/20910459829 > > > > /usr/bin/ld: cannot find -lcurl: No such file or directory > > /usr/bin/ld: cannot find

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread David Carlier
> > It broke the CI on the "all features" build: > > > https://github.com/haproxy/haproxy/actions/runs/7671640626/job/20910459829 > > /usr/bin/ld: cannot find -lcurl: No such file or directory > /usr/bin/ld: cannot find -lzip: No such file or directory > > I'm surprised because CURL_LDFLAGS and LDF

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread Willy Tarreau
On Fri, Jan 26, 2024 at 06:57:57PM +0100, Willy Tarreau wrote: > On Fri, Jan 26, 2024 at 05:38:20PM +, David Carlier wrote: > > I m good with your version. Thanks ! > > Great, now merged, thanks! > Willy It broke the CI on the "all features" build: https://github.com/haproxy/haproxy/actio

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread Willy Tarreau
On Fri, Jan 26, 2024 at 05:38:20PM +, David Carlier wrote: > I m good with your version. Thanks ! Great, now merged, thanks! Willy

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread David Carlier
I m good with your version. Thanks ! On Fri, Jan 26, 2024 at 5:35 PM Willy Tarreau wrote: > On Fri, Jan 26, 2024 at 04:41:36PM +, David Carlier wrote: > > Hi, > > > > Please find the revised patch. > > OK thanks, it looks good and addresses the build issue. > > I noticed that when building w

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread Willy Tarreau
On Fri, Jan 26, 2024 at 04:41:36PM +, David Carlier wrote: > Hi, > > Please find the revised patch. OK thanks, it looks good and addresses the build issue. I noticed that when building with the dummy lib, we continue to link with -lstdc++ even if it's not used (unless DEVICEATLAS_NOCACHE=1)

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread David Carlier
Hi, Please find the revised patch. Regards. On Fri, Jan 26, 2024 at 4:28 PM Willy Tarreau wrote: > Hi David, > > On Thu, Jan 25, 2024 at 09:26:24AM +, David Carlier wrote: > > Finally the last piece related to the da's dummy update and da.c changes. > > Thanks. I'm getting the following bu

Re: PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-26 Thread Willy Tarreau
Hi David, On Thu, Jan 25, 2024 at 09:26:24AM +, David Carlier wrote: > Finally the last piece related to the da's dummy update and da.c changes. Thanks. I'm getting the following build error: addons/deviceatlas/da.c: In function 'da_haproxy_checkinst': addons/deviceatlas/da.c:284:25: war

PATCH 3/3: BUILD/MEDIUM: deviceatlas: addon code update

2024-01-25 Thread David Carlier
Finally the last piece related to the da's dummy update and da.c changes. From df705a30e7d6ce41b61ac7a3e670158b2b2cac25 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Thu, 25 Jan 2024 09:11:18 + Subject: [PATCH 3/3] BUILD/MEDIUM: deviceatlas: updating the addon part. - Reflecing the chang