Re: options forwardfor if-none not playing when an alternative header name is specified

2011-10-09 Thread Willy Tarreau
Hi Sagi, On Sat, Oct 08, 2011 at 10:55:58PM +0200, Sagi Bashari wrote: Patch against 1.5-dev is attached. I ran a quick test against both 1.5-dev and 1.4.18 and it seems to work fine. patch applied to both versions, thanks very much ! Willy

Re: options forwardfor if-none not playing when an alternative header name is specified

2011-10-08 Thread Sagi Bashari
Hi Willy, On Thu, Oct 6, 2011 at 9:54 PM, Willy Tarreau w...@1wt.eu wrote: Hi Sagi, On Thu, Oct 06, 2011 at 04:40:41PM +0200, Sagi Bashari wrote: Hi, I believe I have found a bug in HAProxy v1.4.18. The if-none directive of the forwardfor option always looks for the

options forwardfor if-none not playing when an alternative header name is specified

2011-10-06 Thread Sagi Bashari
Hi, I believe I have found a bug in HAProxy v1.4.18. The if-none directive of the forwardfor option always looks for the X-Forwarded-For header, even if an alternative header name was set. This means that if I use something like: options forwardfor header X-Client-IP if-none Then if the client

Re: options forwardfor if-none not playing when an alternative header name is specified

2011-10-06 Thread Willy Tarreau
Hi Sagi, On Thu, Oct 06, 2011 at 04:40:41PM +0200, Sagi Bashari wrote: Hi, I believe I have found a bug in HAProxy v1.4.18. The if-none directive of the forwardfor option always looks for the X-Forwarded-For header, even if an alternative header name was set. This means that if I use