Constructor java.io.File(String) creates object with incorrect name if
one-letter name is followed by file separator char
--
Key: HARMONY-46
URL: http://issue
[
http://issues.apache.org/jira/browse/HARMONY-45?page=comments#action_12363988 ]
Vladimir Strigun commented on HARMONY-45:
-
Patch is trivial (just check whether the name of charset starts with "x-"):
567c567
< return true;
---
>
[
http://issues.apache.org/jira/browse/HARMONY-45?page=comments#action_12363987 ]
Vladimir Strigun commented on HARMONY-45:
-
Testcase:
package org.apache.harmony.tests.java.nio.charset;
import java.nio.charset.Charset;
import junit.framework.TestC
Charset.isRegistered() method always return true
Key: HARMONY-45
URL: http://issues.apache.org/jira/browse/HARMONY-45
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Vladimir Strigun
Priority: Tri
[
http://issues.apache.org/jira/browse/HARMONY-43?page=comments#action_12363982 ]
Tim Ellison commented on HARMONY-43:
Thanks Ricahrd, I'll review them now.
> Performance enhancement for nio buffers bulk get/put methods
> --
[ http://issues.apache.org/jira/browse/HARMONY-43?page=all ]
Richard Liang updated HARMONY-43:
-
Attachment: OtherBuffer_patch.txt
Hello Tim,
Here is the patch file for all other buffers (except for CharBuffer). The
changes are just similar to those of C
On 1/25/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> Mikhail Loenko wrote:
> > So how will you distinguish if a properly written test passed
> > or skipped?
>
> by testing the test suite as the tests are developed (i.e. running it in
> different configurations and ensuring it does the right thing).
Mikhail Loenko wrote:
> So how will you distinguish if a properly written test passed
> or skipped?
by testing the test suite as the tests are developed (i.e. running it in
different configurations and ensuring it does the right thing).
(Of course, this is the recursive problem of determining te
Isn't the idea to have a shared implementation that both FileChannel
and java.io stream. Can't we just use some sort of reference counting
to close it on finalize?
On 1/25/06, Rodrigo Kumpera <[EMAIL PROTECTED]> wrote:
> On 1/25/06, Paulex Yang <[EMAIL PROTECTED]> wrote:
> > Agree, it should, but
On 1/25/06, Paulex Yang <[EMAIL PROTECTED]> wrote:
> Agree, it should, but currently not in Harmony.
>
> Rodrigo Kumpera wrote:
> > Aren't channels supposed to hold references to the original streams?
> >
> > On 1/24/06, Paulex Yang <[EMAIL PROTECTED]> wrote:
> >
> >> The patch does work in some ca
[ http://issues.apache.org/jira/browse/HARMONY-42?page=all ]
Paulex Yang updated HARMONY-42:
---
Attachment: Harmony42-java_io_FileChannelFactory-patch.txt
Harmony42-java_io_FileOutputStream-patch.txt
A POC refactor patch for java.io.FileOutpu
[ http://issues.apache.org/jira/browse/HARMONY-38?page=all ]
Tim Ellison resolved HARMONY-38:
Resolution: Fixed
Paulex,
Fixed in NIO module at repo revision 372204
- com.ibm.platform.struct.AbstractMemorySpy.java
- com.ibm.platform.struct.Runtime
Agree, it should, but currently not in Harmony.
Rodrigo Kumpera wrote:
Aren't channels supposed to hold references to the original streams?
On 1/24/06, Paulex Yang <[EMAIL PROTECTED]> wrote:
The patch does work in some case, but it is not enough.
First, when the channel is closed, the rele
[ http://issues.apache.org/jira/browse/HARMONY-42?page=all ]
Paulex Yang updated HARMONY-42:
---
Attachment: Harmony42-IFileSystem-patch.txt
Harmony42-IMemorySystem-patch.txt
Sorry that I didn't tell the whole story, the mmap related functions
Aren't channels supposed to hold references to the original streams?
On 1/24/06, Paulex Yang <[EMAIL PROTECTED]> wrote:
> The patch does work in some case, but it is not enough.
>
> First, when the channel is closed, the relevant stream(FileInputStream,
> FileOutputStream or RandomAccessFile) also
Well, copy done ;-)
Tim Ellison wrote:
I accept your point. Since this comment was quite specific to the issue
then it seemed fitting to keep that as a JIRA comment, if a jira comment
opens up a wider consideration then I agree it should be responded to on
the dev list.
In this instance, Paule
[
http://issues.apache.org/jira/browse/HARMONY-40?page=comments#action_12363945 ]
Paulex Yang commented on HARMONY-40:
As Tim asked, copied from my comment on mailing list;)
The patch does work in some case, but it is not enough.
First, when the chann
[
http://issues.apache.org/jira/browse/HARMONY-38?page=comments#action_12363944 ]
Paulex Yang commented on HARMONY-38:
Sorry, there is a typo on my comment above, I meant the patches for
AbstractMemorySpy and RuntimeMemorySpy, as what the attachments' n
[ http://issues.apache.org/jira/browse/HARMONY-38?page=all ]
Paulex Yang updated HARMONY-38:
---
Attachment: Harmony38-AbstractMemorySpy-patch.txt
Harmony38-RuntimeMemorySpy-patch.txt
Thank you, Tim. Here goes the patches for PhantomReference
+1
Anton Avtamonov wrote:
> On 1/25/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
>> One more reason when logs are necessary:
>>
>> If testing is possible in some configurations only
>> (like set of providers contains something or default encoding is ...), then
>> 1) build failing in all different
Geir,
I assume you don't mind me stealing JIRA issues from you ;-)
Are new issues being created as 'Unassigned'? just in case I
accidentally swipe one that you really are working on.
Regards,
Tim
Tim Ellison (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-20?page=all ]
>
>
So how will you distinguish if a properly written test passed
or skipped? Both of them will say 'passed' and you will never
know either it really passed or you config is slightly wrong and
the test was skipped
Thanks,
Mikhail
On 1/25/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> Mikhail Loenko wro
[ http://issues.apache.org/jira/browse/HARMONY-20?page=all ]
Tim Ellison reassigned HARMONY-20:
--
Assign To: Tim Ellison (was: Geir Magnusson Jr)
> java.util.Collections rotate() gives incorrect result with distance parameter
> of min possible integer
I accept your point. Since this comment was quite specific to the issue
then it seemed fitting to keep that as a JIRA comment, if a jira comment
opens up a wider consideration then I agree it should be responded to on
the dev list.
In this instance, Paulex has a good point about why Vladimir's su
On 1/25/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> One more reason when logs are necessary:
>
> If testing is possible in some configurations only
> (like set of providers contains something or default encoding is ...), then
> 1) build failing in all different configs would be annoying
> 2) On
Mikhail Loenko wrote:
> One more reason when logs are necessary:
>
> If testing is possible in some configurations only
> (like set of providers contains something or default encoding is ...), then
> 1) build failing in all different configs would be annoying
huh? if you can determine that the te
One more reason when logs are necessary:
If testing is possible in some configurations only
(like set of providers contains something or default encoding is ...), then
1) build failing in all different configs would be annoying
2) One has to be able to scan logs for warnings to verify that
functio
cool - thanks
Mikhail Loenko (JIRA) wrote:
[ http://issues.apache.org/jira/browse/HARMONY-44?page=all ]
Mikhail Loenko updated HARMONY-44:
--
Attachment: patch.txt
The patch that removes 'logln("==...' from security2 unit tests
some security2 unit
Interesting problem. I do agree with you - keeping it in one place is a
good thing, and JIRA is that place.
However, I always find it hard to read jira comment streams - they don't
feel the same as discussion in regular dev@ mail.
I have no idea what to do about this. I've thought about doi
[ http://issues.apache.org/jira/browse/HARMONY-31?page=all ]
Geir Magnusson Jr updated HARMONY-31:
-
Component: Classlib
> Move peformance timing of unit tests into a decorator class.
>
>
>
[ http://issues.apache.org/jira/browse/HARMONY-39?page=all ]
Geir Magnusson Jr reassigned HARMONY-39:
Assign To: Geir Magnusson Jr
> Contribution of beans, regex and math classlibrary code
> ---
[ http://issues.apache.org/jira/browse/HARMONY-44?page=all ]
Geir Magnusson Jr reassigned HARMONY-44:
Assign To: Geir Magnusson Jr
> some security2 unit tests log redundant information
> ---
>
>
Paulex,
IMHO This would be better as a comment on the JIRA issue itself, then we
can keep them all together. Would you like to repeat yourself there ;-)
Thanks
Tim
Paulex Yang wrote:
> The patch does work in some case, but it is not enough.
>
> First, when the channel is closed, the relevant s
On 1/25/06, Thorbjørn Ravn Andersen <[EMAIL PROTECTED]> wrote:
> Mikhail Loenko wrote:
>
> > fail() is not always convinient, for example, how would you print
> >
> >stack trace to fail()? Meanwhile stacktrace is most often enough
> >
> >
> If you need a stacktrace, why not just throw a RuntimeExce
Well if we need just a single stacktrace per test it would work.
Consider an example: we need to make several attempts
and fail only if all of them fail. For example if we want try to
create an object
whose constructor takes a name of a security algorithm as an argument.
We do not know before whic
Mikhail Loenko wrote:
fail() is not always convinient, for example, how would you print
stack trace to fail()? Meanwhile stacktrace is most often enough
If you need a stacktrace, why not just throw a RuntimeException at that
point? JUnit will then include the stack trace in the report.
-
36 matches
Mail list logo
