Re: [classlib][testing] question about org.apache.harmony.tests.java.nio.channels.SocketChannelTest

2006-07-02 Thread Mikhail Loenko
2006/6/30, Andrew Zhang [EMAIL PROTECTED]: Hello Mikhail, Totally agree with you. assertEquals doesn't make any sense here. I will remove these useless assertEquals in NIO module tests. Great! Thanks! On 6/30/06, Mikhail Loenko [EMAIL PROTECTED] wrote: It is not clear why we have

[classlib][testing] question about org.apache.harmony.tests.java.nio.channels.SocketChannelTest

2006-06-30 Thread Mikhail Loenko
It is not clear why we have assertEquals in this type of constructions try { assertEquals(CAPACITY_NORMAL, this.channel1.read(buf)); fail(Should throw ClosedChannelException); } catch (ClosedChannelException e) { // correct }

Re: [classlib][testing] question about org.apache.harmony.tests.java.nio.channels.SocketChannelTest

2006-06-30 Thread Andrew Zhang
Hello Mikhail, Totally agree with you. assertEquals doesn't make any sense here. I will remove these useless assertEquals in NIO module tests. Thanks! On 6/30/06, Mikhail Loenko [EMAIL PROTECTED] wrote: It is not clear why we have assertEquals in this type of constructions try {