Ilya, so do you vote for non-bug status?
You are right that Shape doesn't follow spec if getBounds2D returns
null - it means Shape implementation is invalid. But Harmony should
follow RI (if it's possible) even if paramters are invalid. In this
case we can follow RI esealy as you suggested to add
OK, I will ask committers to change bug status to non-bug.
2006/9/26, Ilya Okomin <[EMAIL PROTECTED]>:
On 9/26/06, Ilya Okomin <[EMAIL PROTECTED]> wrote:
>
>
>
> On 9/26/06, Denis Kishenko <[EMAIL PROTECTED]> wrote:
> >
> > Ilya, so do you vote for non-bug status?
> >
> > You are right that Shap
On 9/26/06, Ilya Okomin <[EMAIL PROTECTED]> wrote:
On 9/26/06, Denis Kishenko <[EMAIL PROTECTED]> wrote:
>
> Ilya, so do you vote for non-bug status?
>
> You are right that Shape doesn't follow spec if getBounds2D returns
> null - it means Shape implementation is invalid. But Harmony should
>
On 9/26/06, Denis Kishenko <[EMAIL PROTECTED]> wrote:
Ilya, so do you vote for non-bug status?
You are right that Shape doesn't follow spec if getBounds2D returns
null - it means Shape implementation is invalid. But Harmony should
follow RI (if it's possible) even if paramters are invalid. In t
I suggested to return false because spec says for Shape.getBounds2D()
method:
"Returns a high precision and more accurate bounding box of the Shape than
the getBounds method." and "Shape lies entirely within the indicated
Rectangle2D.". Method CubicCurve2D.contains() checks if specified coordinate
2006/9/25, Ilya Okomin <[EMAIL PROTECTED]>:
To follow RI I would suggest to add check (if the bounds2D is null) to the
contains() method, in this case just to return false.
Yep, to follow RI we can check if the bounds2D is null but why you
suggest return false? I think in this case we have to ex
On 9/25/06, Denis Kishenko <[EMAIL PROTECTED]> wrote:
Hi all
I think this is non-bug difference.
If successor of CubicCurve2D returns null instead of bounds then
Harmony throws NPE in contains() method while RI doesn't. It seems
like RI doesn't use getBounds2D() to implement contains() method
Hi all
I think this is non-bug difference.
If successor of CubicCurve2D returns null instead of bounds then
Harmony throws NPE in contains() method while RI doesn't. It seems
like RI doesn't use getBounds2D() to implement contains() method while
Harmony does.
I see three possibilities
1. Exclud