Re: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-05 Thread Alexei Zakharov
I'd say leave the TODOs alone, at least until we're in a phase where such polishing up is desired. Agreed. I've already posted a lot of // XXX investigate messages to myself to be read in the future. Regards, 2006/10/4, Alex Blewitt [EMAIL PROTECTED]: I use TODOs a lot in my code to remind

Re: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-04 Thread Alexey Varlamov
2006/10/4, Nathan Beyer [EMAIL PROTECTED]: If this is an event that should be logged, as the TODO indicated, then why not just print out the stack trace and be done with it? If this exception happens so often that you'd like it removed, then why would we want to log a warning message, which I

Re: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-04 Thread Geir Magnusson Jr.
Stepan Mishura wrote: On 10/4/06, Nathan Beyer wrote: If this is an event that should be logged, as the TODO indicated, then why not just print out the stack trace and be done with it? If this exception happens so often that you'd like it removed, then why would we want to log a warning

Re: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-04 Thread Tim Ellison
Alex Blewitt wrote: I use TODOs a lot in my code to remind me to come back to that particular piece and do the job properly. If someone else were to remove them then they may not do the right thing as far as the code needs ... so I'd expect at least some kind of heads-up before this would

RE: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-04 Thread Nathan Beyer
-Original Message- From: Alexey Varlamov [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 04, 2006 5:13 AM To: harmony-dev@incubator.apache.org Subject: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments 2006/10/4, Nathan Beyer [EMAIL PROTECTED

RE: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-04 Thread Nathan Beyer
-Original Message- From: Tim Ellison [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 04, 2006 11:17 AM To: harmony-dev@incubator.apache.org Subject: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments Alex Blewitt wrote: I use TODOs a lot in my code to remind me

[r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-03 Thread Alexey Varlamov
Nathan, I've seen you dropped many TODOs in - Code cleanup - series of commits; I'd like to know what reasoning was behind this? I think it's a bit early to erase TODOs without appropriate consideration... In particular, could you please undo the following change, it produces garbage messages

Re: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-03 Thread Nathan Beyer
If this is an event that should be logged, as the TODO indicated, then why not just print out the stack trace and be done with it? If this exception happens so often that you'd like it removed, then why would we want to log a warning message, which I would presume would print to the console just

Re: [r451637] - Code cleanup - ... - Remove unnecessary comments

2006-10-03 Thread Stepan Mishura
On 10/4/06, Nathan Beyer wrote: If this is an event that should be logged, as the TODO indicated, then why not just print out the stack trace and be done with it? If this exception happens so often that you'd like it removed, then why would we want to log a warning message, which I would