Re: Where to put the tools.... (was Re: [vote] HARMONY-1410 : JDWP agent for DRLVM)

2006-10-04 Thread Ivan Popov
Yes, JDWP agent uses most of JVMTI functions, and testing JDWP level indirectly checks JVMTI implementation. JDWP unit tests included into JDWP contribution do not provide exhaustive testing, but they often catch problems with basic JVMTI support related to debug functionality. However, there is

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-10-03 Thread Oliver Deakin
+1 Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest or early completion. geir

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-10-03 Thread Tim Ellison
+1 (with apologies for taking so long to complete the review) Tim Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote

Re: Where to put the tools.... (was Re: [vote] HARMONY-1410 : JDWP agent for DRLVM)

2006-10-03 Thread Ivan Popov
Initially I considered putting JDWP agent to classlib as part of JPDA module, so its build is adjusted to the classlib build structure. But I agree that putting it to tools directory (or to jdktools as discussed in separate thread) should be better solution. JDWP agent is not an implementation of

Re: Where to put the tools.... (was Re: [vote] HARMONY-1410 : JDWP agent for DRLVM)

2006-10-03 Thread Geir Magnusson Jr.
Ivan Popov wrote: --- I'd like to see JDWP unit tests included into regular tests runs, they often reveal problems with JVMTI and JNI support when JVM implementation is changed. I'm not sure that unit tests are provided with other tools and included into tests run, and this can be a separate

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-10-02 Thread Mikhail Loenko
+1 2006/9/28, Geir Magnusson Jr. [EMAIL PROTECTED]: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest or early

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-10-01 Thread Stepan Mishura
+1 -Stepan. On 9/28/06, Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest or early

RE: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-29 Thread Nathan Beyer
+1 -Original Message- From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED] Sent: Thursday, September 28, 2006 12:38 AM To: harmony-dev@incubator.apache.org Subject: [vote] HARMONY-1410 : JDWP agent for DRLVM BCC and ACQs are in. What say ye? Would it be nice to debug using

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Mark Hindess
+1 -Mark. On 28 September 2006 at 1:38, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Ivan Volosyuk
+1 from me. -- Ivan Intel Middleware Products Division On 28 September 2006 at 1:38, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Alexey Petrenko
+1 2006/9/28, Ivan Volosyuk [EMAIL PROTECTED]: +1 from me. -- Ivan Intel Middleware Products Division On 28 September 2006 at 1:38, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Paulex Yang
+1 Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest or early completion. geir

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Alexey Varlamov
+1 2006/9/28, Paulex Yang [EMAIL PROTECTED]: +1 Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Oleg Khaschansky
+1, but it seems to me that its build is not aligned with the classlib build structure. Please, correct me if I am wrong. Have somebody tried to build it already? On 9/28/06, Alexey Varlamov [EMAIL PROTECTED] wrote: +1 2006/9/28, Paulex Yang [EMAIL PROTECTED]: +1 Geir Magnusson Jr. wrote:

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Ivan Popov
Yes, build script for JDWP agent should be aligned with the current classlib build structure. It should be easy, because it is generally oriented to the classlib structure and requires just a few changes. I can provide patch for this. I tried to build JDWP agent as a separate classlib component

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Gregory Shimansky
+1 from me On Thursday 28 September 2006 14:25 Oleg Khaschansky wrote: +1, but it seems to me that its build is not aligned with the classlib build structure. Please, correct me if I am wrong. Have somebody tried to build it already? I've built it successfully on Linux but I unpacked JIRA

Where to put the tools.... (was Re: [vote] HARMONY-1410 : JDWP agent for DRLVM)

2006-09-28 Thread Geir Magnusson Jr.
Keeping the discussion out of the vote thread. Both this and javah aren't going into classlib anyway. I was going to suggest we put them into /tools, bring the javac and keytool over, and I volunteer to do it. Then add that to the federated build, and get into the jdk. geir On Sep 28,

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-28 Thread Stefano Mazzocchi
Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest or early completion. +1 -- Stefano.

[vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-27 Thread Geir Magnusson Jr.
BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest or early completion. geir

Re: [vote] HARMONY-1410 : JDWP agent for DRLVM

2006-09-27 Thread Geir Magnusson Jr.
+1 from me On Sep 28, 2006, at 1:38 AM, Geir Magnusson Jr. wrote: BCC and ACQs are in. What say ye? Would it be nice to debug using eclipse debugger in DRLVM? [ ] + 1 accept this contribution into the project [ ] -1 don't accept (please give reason) Vote runs usual 3 days unless protest