Re: EOL differences in svn diffs

2006-03-31 Thread Tim Ellison
Archie Cobbs wrote: Tim Ellison wrote: Can we set up the server to recognize .java / .xml / etc files as text/plain native types? Sounds good to me $ find . -name \*.java -o -name \*.xml \ | xargs svn propset svn:eol-style native \ svn ci -m Set native EOL style Isn't there

Re: EOL differences in svn diffs

2006-03-31 Thread Geir Magnusson Jr
no, it should be able to be set that way once, I thought Tim Ellison wrote: Archie Cobbs wrote: Tim Ellison wrote: Can we set up the server to recognize .java / .xml / etc files as text/plain native types? Sounds good to me $ find . -name \*.java -o -name \*.xml \ | xargs svn

Re: EOL differences in svn diffs

2006-03-31 Thread Etienne Gagnon
Neat page! Could a link to it be added to the Harmony web page, so that new contributors, which are already overwhelmed by information, don't forget to read it? ;-) Etienne Leo Simons wrote: Please see http://www.apache.org/dev/, in particular -- Etienne M. Gagnon, Ph.D.

Re: EOL differences in svn diffs

2006-03-31 Thread Geir Magnusson Jr
Tim Ellison wrote: Ah, thanks Leo. I've set up these options on my svn client so let's see if that fixes it. Still seems strange that every client has to do this rather than making it a server-side config. I think that's the cool thing - the server stores in platform neutral, and just

Re: EOL differences in svn diffs

2006-03-30 Thread Nikolay Kuznetsov
Yes, I saw that too, and I agree that it makes it virtually impossible to see exactly what was changed. I used a windows machine to apply your patch and commit the code, so I can only assume that's why the file was converted to DOS EOL. I'll poke around to see if I can make it preserve the

Re: EOL differences in svn diffs

2006-03-30 Thread Etienne Gagnon
The property works. I has been in use in the SableVM repository for a long time now. Actually, you need to set 2 properties: svn:mime-type : text/plain svn:eol-style : native Note that svn will give you trouble if you try to set these properties on a file which contains mixed EOL types.

Re: EOL differences in svn diffs

2006-03-30 Thread Nikolay Kuznetsov
Actually, you need to set 2 properties: svn:mime-type : text/plain svn:eol-style : native It depends a lot from the svn client, though. I tried this, but in my case files are returning from repository in the format they are stored in repository. Thanks a lot for the comment, I'll try to use

Re: EOL differences in svn diffs

2006-03-30 Thread Tim Ellison
Can we set up the server to recognize .java / .xml / etc files as text/plain native types? Regards, Tim Etienne Gagnon wrote: The property works. I has been in use in the SableVM repository for a long time now. Actually, you need to set 2 properties: svn:mime-type : text/plain

Re: EOL differences in svn diffs

2006-03-30 Thread Archie Cobbs
Tim Ellison wrote: Can we set up the server to recognize .java / .xml / etc files as text/plain native types? Sounds good to me $ find . -name \*.java -o -name \*.xml \ | xargs svn propset svn:eol-style native \ svn ci -m Set native EOL style Etienne Gagnon wrote: Actually, you

Re: EOL differences in svn diffs

2006-03-30 Thread Geir Magnusson Jr
yes - eol-style is the solution here, and I thought SVN did the right thing for obvious text files... geir Archie Cobbs wrote: Tim Ellison wrote: Can we set up the server to recognize .java / .xml / etc files as text/plain native types? Sounds good to me $ find . -name \*.java -o

Re: EOL differences in svn diffs

2006-03-30 Thread Mark Hindess
It would also be helpful to raise a bug against whatever tool Tim is using. It is almost certainly making incorrect assumptions about line endings of files being patched based on eol characters of the metadata. Or possibly assuming the line endings of all files being patched are the same which

EOL differences in svn diffs

2006-03-29 Thread Tim Ellison
Nikolay Kuznetsov (JIRA) wrote: Nikolay Kuznetsov commented on HARMONY-271: --- Tim, tank you very much for so such a quick response and integration. All the changes are in place as was expected. But there is one minor issue, affected files was