Re: [jira] Updated: (HARMONY-491) [classlib] Constructors of java.nio.charset.CharsetEncoder should not throw NPE if charset==null

Hi, Svetlana, Welcome :) Samoilenko, Svetlana V wrote: Hi, Andrew, I've prepared new patch with your fixes. Thank you for your suggestion. Regards, Svetlana -Original Message- From: Andrew Zhang [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 24, 2006 8:34 AM To:

RE: [jira] Updated: (HARMONY-491) [classlib] Constructors of java.nio.charset.CharsetEncoder should not throw NPE if charset==null

Hi, Andrew, I've prepared new patch with your fixes. Thank you for your suggestion. Regards, Svetlana -Original Message- From: Andrew Zhang [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 24, 2006 8:34 AM To: harmony-dev@incubator.apache.org Subject: Re: [jira] Updated: (HARMONY-491)

Re: [jira] Updated: (HARMONY-491) [classlib] Constructors of java.nio.charset.CharsetEncoder should not throw NPE if charset==null

Hi, Svetlana, Welcome :) On 5/24/06, Samoilenko, Svetlana V [EMAIL PROTECTED] wrote: Hi, Andrew, I've prepared new patch with your fixes. Thank you for your suggestion. Regards, Svetlana -Original Message- From: Andrew Zhang [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 24, 2006

Re: [jira] Updated: (HARMONY-491) [classlib] Constructors of java.nio.charset.CharsetEncoder should not throw NPE if charset==null

Hi, Svetlana I took a quick view on your patch, I found your quick fix didn't resolve the problem thoroughly. Try to comment following code in your test case, RI fails on the test case but Harmony with your patch passes. public boolean isLegalReplacement(byte[] arg0) { return true;