[Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-16 Thread Bit Connor
Hello, I have reported this problem to the maintainer of the HTTP package about 2 weeks ago, but have not yet received a response, so I am reporting it here. I am using a recent git check out of HTTP 4000.0.10 The bufferReadLine function from Network.TCP has a bug in how it handles an IOException

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-16 Thread Claus Reinke
After it catches this error, the function returns (line 376): return (fail (show e)) The "fail" is running in the Either monad (The Result type = Either). This calls the default Monad implementation of fail, which is just a call to plain old error. This basically causes the entire program to cra

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-21 Thread Bit Connor
On Sat, Oct 16, 2010 at 10:29 AM, Claus Reinke wrote: >> After it catches this error, the function returns (line 376): >> >> return (fail (show e)) >> >> The "fail" is running in the Either monad (The Result type = Either). >> This calls the default Monad implementation of fail, which is just a >>

RE: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-22 Thread Sittampalam, Ganesh
Bit Connor wrote: > On Sat, Oct 16, 2010 at 10:29 AM, Claus Reinke > wrote: >>> After it catches this error, the function returns (line 376): >>> >>> return (fail (show e)) >>> >>> The "fail" is running in the Either monad (The Result type = >>> Either). This calls the default Monad implementat

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-22 Thread Sigbjorn Finne
On Fri, Oct 22, 2010 at 9:35 AM, Sittampalam, Ganesh < ganesh.sittampa...@credit-suisse.com> wrote: > Bit Connor wrote: > > On Sat, Oct 16, 2010 at 10:29 AM, Claus Reinke > > wrote: > >>> After it catches this error, the function returns (line 376): > >>> > >>> return (fail (show e)) > >>> > >>>

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-22 Thread Michael Snoyman
On Fri, Oct 22, 2010 at 11:36 AM, Sigbjorn Finne wrote: > > > On Fri, Oct 22, 2010 at 9:35 AM, Sittampalam, Ganesh > wrote: >> >> Bit Connor wrote: >> > On Sat, Oct 16, 2010 at 10:29 AM, Claus Reinke >> > wrote: >> >>> After it catches this error, the function returns (line 376): >> >>> >> >>> r

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-23 Thread Ganesh Sittampalam
Hi Bit, On Thu, 21 Oct 2010, Bit Connor wrote: On Sat, Oct 16, 2010 at 10:29 AM, Claus Reinke wrote: After it catches this error, the function returns (line 376): return (fail (show e)) The "fail" is running in the Either monad (The Result type = Either). This calls the default Monad implem

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-23 Thread Bit Connor
On Sat, Oct 23, 2010 at 8:49 PM, Ganesh Sittampalam wrote: > Hi Bit, > > On Thu, 21 Oct 2010, Bit Connor wrote: > >> On Sat, Oct 16, 2010 at 10:29 AM, Claus Reinke >> wrote: After it catches this error, the function returns (line 376): return (fail (show e)) The "fai

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-24 Thread Ganesh Sittampalam
On Sun, 24 Oct 2010, Bit Connor wrote: On Sat, Oct 23, 2010 at 8:49 PM, Ganesh Sittampalam wrote: I'm just looking at fixing this so I can make an upload as discussed with Sigbjorn. I guess the best thing to do is to make all the calls to fail into something more explicit. Yep. Ideally, sim

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-10-29 Thread Ganesh Sittampalam
On Fri, 22 Oct 2010, Sigbjorn Finne wrote: On Fri, Oct 22, 2010 at 9:35 AM, Sittampalam, Ganesh < ganesh.sittampa...@credit-suisse.com> wrote: libraries@, what's the right way to proceed? Can I make a Debian-style "non-maintainer upload" with minimal changes to fix urgent issues like these?

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-11-03 Thread Simon Marlow
On 29/10/2010 23:24, Ganesh Sittampalam wrote: On Fri, 22 Oct 2010, Sigbjorn Finne wrote: On Fri, Oct 22, 2010 at 9:35 AM, Sittampalam, Ganesh < ganesh.sittampa...@credit-suisse.com> wrote: libraries@, what's the right way to proceed? Can I make a Debian-style "non-maintainer upload" with min

Re: [Haskell-cafe] Bug in HTTP (bad internal error handling)

2010-11-03 Thread Ganesh Sittampalam
On Wed, 3 Nov 2010, Simon Marlow wrote: On 29/10/2010 23:24, Ganesh Sittampalam wrote: 4000.0.10 should fix the reported issue with fail and Either, and bumps the base dep to build with GHC 7.0 That's great. Any chance you could also look at this one, which appears to be a pretty serious b