Re: [DISCUSS] Merging PRs vs. commit from CLI and keep committer field

2021-10-30 Thread Ayush Saxena
Hey Sean, I just gave a try to Github CLI and merged a PR, using the command: *gh pr merge 3600 --squash --body "HDFS-16290.--Message--"* Unfortunately this also has the same result, nothing different. -Ayush On Tue, 26 Oct 2021 at 21:25, Sean Busbey wrote: > If you add a line in the commit

Re: [DISCUSS] Merging PRs vs. commit from CLI and keep committer field

2021-10-26 Thread Sean Busbey
If you add a line in the commit message that the commit closes a given PR # then GitHub will annotate the PR as related to the specific commit and close it for you. i.e. you can add “closes #3454” to the commit message body and then PR 3454 will close and link to that commit when it hits the de

Re: [DISCUSS] Merging PRs vs. commit from CLI and keep committer field

2021-10-25 Thread Szilárd Németh
Hi Ayush, Thanks a lot for your response. > Yahh, remember chasing Github support regarding this last year and they > reverted back that they are aware of this and have an internal jira for > this but can not comment upon how much time it would take. (As of now 1 > year & counting) > So if I get

Re: [DISCUSS] Merging PRs vs. commit from CLI and keep committer field

2021-10-19 Thread Ayush Saxena
Yahh, remember chasing Github support regarding this last year and they reverted back that they are aware of this and have an internal jira for this but can not comment upon how much time it would take. (As of now 1 year & counting) As far as I remember this is with squash & commit only. If you

[DISCUSS] Merging PRs vs. commit from CLI and keep committer field

2021-10-19 Thread Szilárd Németh
Hi, I noticed something strange in our commits, in particular the committer field is not reflecting the user who committed the commit. *1. First, I wanted to check Gergely's commits from the last month or so. This was getting to be suspicious as I expected to see a bunch of commits from Sept / Oc