Nanda kumar created HDDS-1854:
---------------------------------

             Summary: Print intuitive error message at client when the pipeline 
returned by SCM has no datanode
                 Key: HDDS-1854
                 URL: https://issues.apache.org/jira/browse/HDDS-1854
             Project: Hadoop Distributed Data Store
          Issue Type: Improvement
          Components: Ozone Client
            Reporter: Nanda kumar


We are throwing {{IllegalArgumentException}} in OzoneClient when the pipeline 
returned by SCM doesn't have any datanode information. Instead of throwing 
{{IllegalArgumentException}}, we can throw custom user friendly exception which 
is easy to understand.
Existing exception trace:
{noformat}
AssertionError: Ozone get Key failed with 
output=[java.lang.IllegalArgumentException
        at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:72)
        at 
org.apache.hadoop.hdds.scm.XceiverClientManager.acquireClient(XceiverClientManager.java:150)
        at 
org.apache.hadoop.hdds.scm.XceiverClientManager.acquireClientForReadData(XceiverClientManager.java:143)
        at 
org.apache.hadoop.hdds.scm.storage.BlockInputStream.getChunkInfos(BlockInputStream.java:154)
        at 
org.apache.hadoop.hdds.scm.storage.BlockInputStream.initialize(BlockInputStream.java:118)
        at 
org.apache.hadoop.hdds.scm.storage.BlockInputStream.read(BlockInputStream.java:222)
        at 
org.apache.hadoop.ozone.client.io.KeyInputStream.read(KeyInputStream.java:171)
        at 
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(OzoneInputStream.java:47)
        at java.base/java.io.InputStream.read(InputStream.java:205)
        at org.apache.hadoop.io.IOUtils.copyBytes(IOUtils.java:94)
        at 
org.apache.hadoop.ozone.web.ozShell.keys.GetKeyHandler.call(GetKeyHandler.java:98)
        at 
org.apache.hadoop.ozone.web.ozShell.keys.GetKeyHandler.call(GetKeyHandler.java:48)
        at picocli.CommandLine.execute(CommandLine.java:1173)
        at picocli.CommandLine.access$800(CommandLine.java:141)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:1367)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:1335)
        at 
picocli.CommandLine$AbstractParseResultHandler.handleParseResult(CommandLine.java:1243)
        at picocli.CommandLine.parseWithHandlers(CommandLine.java:1526)
        at picocli.CommandLine.parseWithHandler(CommandLine.java:1465)
        at org.apache.hadoop.hdds.cli.GenericCli.execute(GenericCli.java:65)
        at 
org.apache.hadoop.ozone.web.ozShell.OzoneShell.execute(OzoneShell.java:60)
        at org.apache.hadoop.hdds.cli.GenericCli.run(GenericCli.java:56)
        at 
org.apache.hadoop.ozone.web.ozShell.OzoneShell.main(OzoneShell.java:53)]
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to