Adam Antal created HDFS-14203: --------------------------------- Summary: Refactor OIV Delimited output entry building mechanism Key: HDFS-14203 URL: https://issues.apache.org/jira/browse/HDFS-14203 Project: Hadoop HDFS Issue Type: Improvement Components: tools Affects Versions: 3.2.0 Reporter: Adam Antal
As of some recent improvements in the OIV tool, fields are getting added. For sustainability I propose to introduce a Builder pattern in {{PBImageDelimitedTextWriter}}, which is also prettier than constructing entries like this: {code:java} case SYMLINK: INodeSymlink s = inode.getSymlink(); p = getPermission(s.getPermission()); append(buffer, 0); // Replication append(buffer, formatDate(s.getModificationTime())); append(buffer, formatDate(s.getAccessTime())); append(buffer, 0); // Block size. append(buffer, 0); // Num blocks. append(buffer, 0); // Num bytes. append(buffer, 0); // NS_QUOTA append(buffer, 0); // DS_QUOTA {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org