[
https://issues.apache.org/jira/browse/HDFS-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal resolved HDFS-7144.
---------------------------------
Resolution: Fixed
Fix Version/s: HDFS-6581
Hadoop Flags: Reviewed
+1 thanks a lot for helping out with this Nicholas!
Committed to the feature branch.
> Fix findbugs warnings in RamDiskReplicaTracker
> ----------------------------------------------
>
> Key: HDFS-7144
> URL: https://issues.apache.org/jira/browse/HDFS-7144
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Fix For: HDFS-6581
>
> Attachments: h7144_20140925.patch
>
>
> Two more findbugs warnings:
> - Bad practice Warnings
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles()
> ignores exceptional return value of java.io.File.delete()
> Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details)
> In class
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica
> In method
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles()
> Called method java.io.File.delete()
> At RamDiskReplicaTracker.java:[line 122]
> Another occurrence at RamDiskReplicaTracker.java:[line 127]
> - Dodgy Warnings
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru
> doesn't override RamDiskReplicaTracker$RamDiskReplica.equals(Object)
> Bug type EQ_DOESNT_OVERRIDE_EQUALS (click for details)
> In class
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru
> Did you intend to override
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.equals(Object)
> At RamDiskReplicaLruTracker.java:[lines 37-42]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
