Re: Commits breaking compilation of MR 'classic' tests

2012-09-27 Thread Alejandro Abdelnur
If I recall correctly many of the tests where ported over and only the ones depending on JT/TT stuff were not, no? Thx On Thu, Sep 27, 2012 at 7:44 AM, Thomas Graves wrote: > So is someone signing up to do this port soon? Otherwise I don't see the > point in us spending time keeping tests that

Re: Commits breaking compilation of MR 'classic' tests

2012-09-27 Thread Thomas Graves
So is someone signing up to do this port soon? Otherwise I don't see the point in us spending time keeping tests that mostly don't apply working. I used to spend a lot of time on this when we still had to compile contrib stuff out of ant and the majority of it was just fixing it so it compiles aga

Re: Commits breaking compilation of MR 'classic' tests

2012-09-26 Thread Robert Evans
;yarn-...@hadoop.apache.org<mailto:yarn-...@hadoop.apache.org>" mailto:yarn-...@hadoop.apache.org>>, "mapreduce-...@hadoop.apache.org<mailto:mapreduce-...@hadoop.apache.org>" mailto:mapreduce-...@hadoop.apache.org>> Subject: Re: Commits breaking compilation of

Re: Commits breaking compilation of MR 'classic' tests

2012-09-26 Thread Arun C Murthy
Fair, however there are still tests which need to be ported over. We can remove them after the port. On Sep 26, 2012, at 9:54 AM, Robert Evans wrote: > As per my comment on the bug. I though we were going to remove them. > > MAPREDUCE-4266 only needs a little bit more work, change a patch to a

Re: Commits breaking compilation of MR 'classic' tests

2012-09-26 Thread Robert Evans
As per my comment on the bug. I though we were going to remove them. MAPREDUCE-4266 only needs a little bit more work, change a patch to a script, before they disappear entirely. I would much rather see dead code die then be maintained for a few tests that are mostly testing the dead code itself

Re: Commits breaking compilation of MR 'classic' tests

2012-09-26 Thread Arun C Murthy
Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687 to track this. On Sep 25, 2012, at 9:33 PM, Eli Collins wrote: > How about adding this step to the MR PreCommit jenkins job so it's run > as part test-patch? > > On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy wrote: >> Com

Re: Commits breaking compilation of MR 'classic' tests

2012-09-25 Thread Eli Collins
How about adding this step to the MR PreCommit jenkins job so it's run as part test-patch? On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy wrote: > Committers, > > As most people are aware, the MapReduce 'classic' tests (in > hadoop-mapreduce-project/src/test) still need to built using ant since

Commits breaking compilation of MR 'classic' tests

2012-09-25 Thread Arun C Murthy
Committers, As most people are aware, the MapReduce 'classic' tests (in hadoop-mapreduce-project/src/test) still need to built using ant since they aren't mavenized yet. I've seen several commits (and 2 within the last hour i.e. MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe dev