[
https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226583#comment-13226583
]
Eli Collins commented on HDFS-3004:
---
HDFS-3004.008.patch has a bunch of other stuff in it
[
https://issues.apache.org/jira/browse/HDFS-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226399#comment-13226399
]
Eli Collins commented on HDFS-3066:
---
+1 pending jenkins
> cap space usag
[
https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226395#comment-13226395
]
Eli Collins commented on HDFS-2303:
---
+1 Latest patch (HDFS-2303-5-trunk.patch) looks gre
[
https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226378#comment-13226378
]
Eli Collins commented on HDFS-3004:
---
Your comments above make sense, thanks for the expla
[
https://issues.apache.org/jira/browse/HDFS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226273#comment-13226273
]
Eli Collins commented on HDFS-1623:
---
+1 branch 23 patch looks good to me
[
https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225327#comment-13225327
]
Eli Collins commented on HDFS-2303:
---
Mingjie,
- Have you verified you can set JSVC_HOME
[
https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224940#comment-13224940
]
Eli Collins commented on HDFS-2303:
---
Sounds good, it's only for the error message since w
[
https://issues.apache.org/jira/browse/HDFS-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224814#comment-13224814
]
Eli Collins commented on HDFS-2288:
---
Ah, never mind this is the TestLogRolling#testLogRol
[
https://issues.apache.org/jira/browse/HDFS-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224813#comment-13224813
]
Eli Collins commented on HDFS-2288:
---
Hey Todd,
I think you're right, there's a bug in th
[
https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224764#comment-13224764
]
Eli Collins commented on HDFS-2303:
---
Agree w Tucu, Mingjie, Roman, ATM, on the approach.
[
https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224698#comment-13224698
]
Eli Collins commented on HDFS-3004:
---
Overall approach looks good.
- Wr edit logs in the
[
https://issues.apache.org/jira/browse/HDFS-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224567#comment-13224567
]
Eli Collins commented on HDFS-2872:
---
+1 looks good. I ran a build and reloaded the edits
[
https://issues.apache.org/jira/browse/HDFS-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223759#comment-13223759
]
Eli Collins commented on HDFS-2872:
---
Some nits, otherwise looks great.
- I'd throw IOE i
[
https://issues.apache.org/jira/browse/HDFS-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222585#comment-13222585
]
Eli Collins commented on HDFS-3048:
---
Here's an example NPE seen in a unit test.
{noforma
[
https://issues.apache.org/jira/browse/HDFS-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220228#comment-13220228
]
Eli Collins commented on HDFS-3035:
---
+1 looks good
> HA: fix failure of
[
https://issues.apache.org/jira/browse/HDFS-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219667#comment-13219667
]
Eli Collins commented on HDFS-3025:
---
+1 looks good
> Automatic log sync
[
https://issues.apache.org/jira/browse/HDFS-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219657#comment-13219657
]
Eli Collins commented on HDFS-2979:
---
+1
> HA: Balancer should use logica
[
https://issues.apache.org/jira/browse/HDFS-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219622#comment-13219622
]
Eli Collins commented on HDFS-2979:
---
Let's add a wrapper for getNameServiceUris, somethin
[
https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219611#comment-13219611
]
Eli Collins commented on HDFS-3023:
---
Hey Todd, reviewed the patch again. +1, thanks for a
[
https://issues.apache.org/jira/browse/HDFS-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219578#comment-13219578
]
Eli Collins commented on HDFS-3027:
---
+1
> HA: Implement a simple NN heal
[
https://issues.apache.org/jira/browse/HDFS-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219453#comment-13219453
]
Eli Collins commented on HDFS-3020:
---
+1 updated patch lgtm
> Auto-logSyn
[
https://issues.apache.org/jira/browse/HDFS-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219385#comment-13219385
]
Eli Collins commented on HDFS-2979:
---
- The new getNNUris method seems overloaded, eg it o
[
https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218881#comment-13218881
]
Eli Collins commented on HDFS-3004:
---
Hey Colin,
Nice writeup. Worth mentioning the foc
[
https://issues.apache.org/jira/browse/HDFS-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218874#comment-13218874
]
Eli Collins commented on HDFS-2992:
---
Hey Colin,
Looks like TestFSEditLogLoader.testDispl
[
https://issues.apache.org/jira/browse/HDFS-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218828#comment-13218828
]
Eli Collins commented on HDFS-3027:
---
Looks like NNResourceChecker#hasAvailableDiskSpace d
[
https://issues.apache.org/jira/browse/HDFS-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218773#comment-13218773
]
Eli Collins commented on HDFS-3025:
---
+1 pending jenkins
> Automatic log
[
https://issues.apache.org/jira/browse/HDFS-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218753#comment-13218753
]
Eli Collins commented on HDFS-3026:
---
bq. bq. Wrt delayed shutdown, we likely have (or sho
[
https://issues.apache.org/jira/browse/HDFS-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218729#comment-13218729
]
Eli Collins commented on HDFS-3027:
---
Yea, feel free to punt the specific message to anoth
[
https://issues.apache.org/jira/browse/HDFS-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218692#comment-13218692
]
Eli Collins commented on HDFS-2920:
---
+1
> HA: fix remaining TODO items
>
[
https://issues.apache.org/jira/browse/HDFS-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218453#comment-13218453
]
Eli Collins commented on HDFS-3020:
---
+1 update looks good
> Auto-logSync
[
https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218437#comment-13218437
]
Eli Collins commented on HDFS-3023:
---
Thanks for the info wrt perf, makes sense. Will be i
[
https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218383#comment-13218383
]
Eli Collins commented on HDFS-3023:
---
Thanks for the info. By option #2 vs option #3 abov
[
https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218382#comment-13218382
]
Eli Collins commented on HDFS-3023:
---
Thanks for the info. By option #2 vs option #3 abov
[
https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218378#comment-13218378
]
Eli Collins commented on HDFS-3023:
---
The patch looks good btw, though why does updating b
[
https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218365#comment-13218365
]
Eli Collins commented on HDFS-3023:
---
Is log size a proxy for performance? Ie do we have
[
https://issues.apache.org/jira/browse/HDFS-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218355#comment-13218355
]
Eli Collins commented on HDFS-2958:
---
+1 looks great. This is much nicer! I tried to see i
[
https://issues.apache.org/jira/browse/HDFS-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218336#comment-13218336
]
Eli Collins commented on HDFS-2992:
---
+1 looks good
> Edit log failure tr
[
https://issues.apache.org/jira/browse/HDFS-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218320#comment-13218320
]
Eli Collins commented on HDFS-2920:
---
Hey ATM, how about putting the NN health check imple
[
https://issues.apache.org/jira/browse/HDFS-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218301#comment-13218301
]
Eli Collins commented on HDFS-3024:
---
+1 looks good
> Improve performance
[
https://issues.apache.org/jira/browse/HDFS-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216995#comment-13216995
]
Eli Collins commented on HDFS-3006:
---
bq. - reverts the change in HttpFs since the simple
[
https://issues.apache.org/jira/browse/HDFS-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215361#comment-13215361
]
Eli Collins commented on HDFS-3006:
---
Is this true of HttpFS as well?
> W
[
https://issues.apache.org/jira/browse/HDFS-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214938#comment-13214938
]
Eli Collins commented on HDFS-2995:
---
Verified with a tarball that a 2NN is not started/st
[
https://issues.apache.org/jira/browse/HDFS-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214174#comment-13214174
]
Eli Collins commented on HDFS-2920:
---
+1 looks good
> HA: fix remaining T
[
https://issues.apache.org/jira/browse/HDFS-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214080#comment-13214080
]
Eli Collins commented on HDFS-2922:
---
Forgot to mention, I'm re-running the hdfs tests for
[
https://issues.apache.org/jira/browse/HDFS-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213932#comment-13213932
]
Eli Collins commented on HDFS-2971:
---
Suresh,
The highest gen stamp in an image or log te
[
https://issues.apache.org/jira/browse/HDFS-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207523#comment-13207523
]
Eli Collins commented on HDFS-2943:
---
+1 looks great
> Expose last checkp
[
https://issues.apache.org/jira/browse/HDFS-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207518#comment-13207518
]
Eli Collins commented on HDFS-2947:
---
+1 looks good
> HA: On startup NN t
[
https://issues.apache.org/jira/browse/HDFS-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207515#comment-13207515
]
Eli Collins commented on HDFS-2942:
---
+1 looks good
> HA: TestActiveStand
[
https://issues.apache.org/jira/browse/HDFS-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207146#comment-13207146
]
Eli Collins commented on HDFS-2944:
---
+1
> Typo in hdfs-default.xml cause
[
https://issues.apache.org/jira/browse/HDFS-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205265#comment-13205265
]
Eli Collins commented on HDFS-2935:
---
Why nnId? Since the shared dir is shared it should j
[
https://issues.apache.org/jira/browse/HDFS-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205122#comment-13205122
]
Eli Collins commented on HDFS-2878:
---
+1 looks good
> TestBlockRecovery d
[
https://issues.apache.org/jira/browse/HDFS-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204931#comment-13204931
]
Eli Collins commented on HDFS-2781:
---
Can we define this away? Eg if a standby loses conne
[
https://issues.apache.org/jira/browse/HDFS-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204918#comment-13204918
]
Eli Collins commented on HDFS-2781:
---
If we change the behavior such that the NN drops int
[
https://issues.apache.org/jira/browse/HDFS-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204809#comment-13204809
]
Eli Collins commented on HDFS-2917:
---
Thank you both for the reviews.
@Jitendra, filed HD
[
https://issues.apache.org/jira/browse/HDFS-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204293#comment-13204293
]
Eli Collins commented on HDFS-2579:
---
+1 latest patch and testing looks good.
[
https://issues.apache.org/jira/browse/HDFS-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204272#comment-13204272
]
Eli Collins commented on HDFS-2923:
---
+1 I looked for other similar mistakes in HDFS-1763
[
https://issues.apache.org/jira/browse/HDFS-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203208#comment-13203208
]
Eli Collins commented on HDFS-2764:
---
+1 nice find.
I'd add a comment like the following
[
https://issues.apache.org/jira/browse/HDFS-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203121#comment-13203121
]
Eli Collins commented on HDFS-2362:
---
Not for 23.1, which is getting cut soon. We'll merge
[
https://issues.apache.org/jira/browse/HDFS-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203064#comment-13203064
]
Eli Collins commented on HDFS-2911:
---
HDFS isn't really an application. If we labor on sub
[
https://issues.apache.org/jira/browse/HDFS-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202913#comment-13202913
]
Eli Collins commented on HDFS-2579:
---
+1 updated patch lgtm
Jitendra, if you're going to
[
https://issues.apache.org/jira/browse/HDFS-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201923#comment-13201923
]
Eli Collins commented on HDFS-2902:
---
Correct, the checkpoint may be eg hourly so the admi
[
https://issues.apache.org/jira/browse/HDFS-2782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201897#comment-13201897
]
Eli Collins commented on HDFS-2782:
---
There's also a variant of solution #2 where you don'
[
https://issues.apache.org/jira/browse/HDFS-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201828#comment-13201828
]
Eli Collins commented on HDFS-2794:
---
Ignore my previous comment, was on a stale page. La
[
https://issues.apache.org/jira/browse/HDFS-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201826#comment-13201826
]
Eli Collins commented on HDFS-2794:
---
Todd, new comment looks good. Per last comment the p
[
https://issues.apache.org/jira/browse/HDFS-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201666#comment-13201666
]
Eli Collins commented on HDFS-2794:
---
Nit: the new parameter in hdfs-default.xml is missin
[
https://issues.apache.org/jira/browse/HDFS-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201160#comment-13201160
]
Eli Collins commented on HDFS-2733:
---
Looks good. Comments follow.
* Might make sense to
[
https://issues.apache.org/jira/browse/HDFS-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201128#comment-13201128
]
Eli Collins commented on HDFS-2794:
---
I like this approach better too. Patch looks good.
[
https://issues.apache.org/jira/browse/HDFS-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201120#comment-13201120
]
Eli Collins commented on HDFS-2819:
---
Oops, meant HDFS-2733 in that last comment.
[
https://issues.apache.org/jira/browse/HDFS-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201021#comment-13201021
]
Eli Collins commented on HDFS-2579:
---
+1 looks good
Nits:
- All the SecretManager start/s
[
https://issues.apache.org/jira/browse/HDFS-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200951#comment-13200951
]
Eli Collins commented on HDFS-2894:
---
The bug here is that in the HA branch we're now trea
[
https://issues.apache.org/jira/browse/HDFS-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200880#comment-13200880
]
Eli Collins commented on HDFS-2579:
---
Sounds good to me.
> Starting deleg
[
https://issues.apache.org/jira/browse/HDFS-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200837#comment-13200837
]
Eli Collins commented on HDFS-2868:
---
+1 thanks Harsh!
> Add number of a
[
https://issues.apache.org/jira/browse/HDFS-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200825#comment-13200825
]
Eli Collins commented on HDFS-2868:
---
Looks good Harsh.
Nits:
- I'd make the comment "@Ov
[
https://issues.apache.org/jira/browse/HDFS-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200587#comment-13200587
]
Eli Collins commented on HDFS-2893:
---
Actually, I don't see why sbin/start-dfs.sh checks t
[
https://issues.apache.org/jira/browse/HDFS-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200228#comment-13200228
]
Eli Collins commented on HDFS-2769:
---
Shared storage does not imply a single point of fail
[
https://issues.apache.org/jira/browse/HDFS-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199495#comment-13199495
]
Eli Collins commented on HDFS-2792:
---
How about the following?
- hdfs fsck should not requ
[
https://issues.apache.org/jira/browse/HDFS-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199489#comment-13199489
]
Eli Collins commented on HDFS-2769:
---
+1
> HA: When HA is enabled with a
[
https://issues.apache.org/jira/browse/HDFS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199441#comment-13199441
]
Eli Collins commented on HDFS-2860:
---
+1 sorry should have caught this when filing!
[
https://issues.apache.org/jira/browse/HDFS-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199059#comment-13199059
]
Eli Collins commented on HDFS-2808:
---
s/"slash"/"dash"/
> HA: Use logical
[
https://issues.apache.org/jira/browse/HDFS-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198941#comment-13198941
]
Eli Collins commented on HDFS-2861:
---
+1 lgtm
> HA: checkpointing should
[
https://issues.apache.org/jira/browse/HDFS-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198046#comment-13198046
]
Eli Collins commented on HDFS-2870:
---
+1
> HA: Remove some INFO level log
[
https://issues.apache.org/jira/browse/HDFS-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197597#comment-13197597
]
Eli Collins commented on HDFS-2861:
---
+1
Nit, would add an assert or comment that HTTP_A
[
https://issues.apache.org/jira/browse/HDFS-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197589#comment-13197589
]
Eli Collins commented on HDFS-2742:
---
Todd, thanks for the detailed explanation! +1 to th
[
https://issues.apache.org/jira/browse/HDFS-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197458#comment-13197458
]
Eli Collins commented on HDFS-2292:
---
There are three separate cases to handle:
# web UI
#
[
https://issues.apache.org/jira/browse/HDFS-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197090#comment-13197090
]
Eli Collins commented on HDFS-2857:
---
+1 lgtm. Mind merging to 23? Would be good to have t
[
https://issues.apache.org/jira/browse/HDFS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196668#comment-13196668
]
Eli Collins commented on HDFS-2860:
---
Here's the failing assert:
{noformat}
junit.framewo
[
https://issues.apache.org/jira/browse/HDFS-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196648#comment-13196648
]
Eli Collins commented on HDFS-2853:
---
+1
Nit: MiniDFSCluster#formatSharedEditsDir might b
[
https://issues.apache.org/jira/browse/HDFS-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195900#comment-13195900
]
Eli Collins commented on HDFS-2742:
---
bq. I don't entirely follow what you're getting at h
[
https://issues.apache.org/jira/browse/HDFS-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195897#comment-13195897
]
Eli Collins commented on HDFS-2791:
---
bq. Eli: >... overloading the notion of a corrupt bl
[
https://issues.apache.org/jira/browse/HDFS-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195895#comment-13195895
]
Eli Collins commented on HDFS-2691:
---
+1 looks great
> HA: Tests and fix
[
https://issues.apache.org/jira/browse/HDFS-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195247#comment-13195247
]
Eli Collins commented on HDFS-2840:
---
+1 lgtm
> TestHostnameFilter should
[
https://issues.apache.org/jira/browse/HDFS-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195215#comment-13195215
]
Eli Collins commented on HDFS-2851:
---
Wonder if this is fixed by HDFS-1105. Would be good
[
https://issues.apache.org/jira/browse/HDFS-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195002#comment-13195002
]
Eli Collins commented on HDFS-2833:
---
getmerge is an FsShell API, not a FileSystem/Context
[
https://issues.apache.org/jira/browse/HDFS-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194287#comment-13194287
]
Eli Collins commented on HDFS-2838:
---
+1 nice test.
> NPE in FSNamesyste
[
https://issues.apache.org/jira/browse/HDFS-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193442#comment-13193442
]
Eli Collins commented on HDFS-2691:
---
Sorry for chiming in late. I think solution #1 is pr
[
https://issues.apache.org/jira/browse/HDFS-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193418#comment-13193418
]
Eli Collins commented on HDFS-2791:
---
I think the current patch is preferable, am +1 on it
[
https://issues.apache.org/jira/browse/HDFS-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193341#comment-13193341
]
Eli Collins commented on HDFS-2742:
---
Todd,
Approach in the latest patch looks good to me
[
https://issues.apache.org/jira/browse/HDFS-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192826#comment-13192826
]
Eli Collins commented on HDFS-2838:
---
No worries. Greg is going to take a stab at moving t
[
https://issues.apache.org/jira/browse/HDFS-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192808#comment-13192808
]
Eli Collins commented on HDFS-2838:
---
+1
> NPE in FSNamesystem when in sa
[
https://issues.apache.org/jira/browse/HDFS-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191539#comment-13191539
]
Eli Collins commented on HDFS-2804:
---
Still looks good =)
> SBN should no
101 - 200 of 384 matches
Mail list logo
