[
https://issues.apache.org/jira/browse/HDFS-16242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Antal reassigned HDFS-16242:
---------------------------------
Assignee: Max Xie
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
> Affects Versions: 3.4.0
> Reporter: Max Xie
> Assignee: Max Xie
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
> ...
> },
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
> "Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
