[ 
https://issues.apache.org/jira/browse/HDFS-9593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

BELUGA BEHR reassigned HDFS-9593:
---------------------------------

    Assignee: BELUGA BEHR

> BlockTokenIdentifier Code Review
> --------------------------------
>
>                 Key: HDFS-9593
>                 URL: https://issues.apache.org/jira/browse/HDFS-9593
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: BlockTokenIdentifier.HDFS-9593.patch
>
>
> Please find attached a code review of BlockTokenIdentifier.
> The only real change is using an explicit StringBuilder instead of an 
> implicit one so that the internal buffer may be set more appropriately and 
> checking for zero-length string instead of comparing to an empty string.  The 
> relatively small default buffer of 16 bytes would need to be expanded several 
> times to fit the incoming string.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to