[ https://issues.apache.org/jira/browse/HDFS-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997270#comment-15997270 ]
Rushabh S Shah edited comment on HDFS-11702 at 5/4/17 7:17 PM: --------------------------------------------------------------- Thanks [~hanishakoneru] [~andrew.wang] for the reviews. bq. though is there a unit test for this new behavior? The test case from HADOOP-14104 are still valid tests. I was explicitly calling setKeyProvider(null) from test cases to make sure it doesn't cache indefinitely. was (Author: shahrs87): Thanks [~hanishakoneru] [~andrew.wang] for the reviews. bq. though is there a unit test for this new behavior? The test case from HADOOP-14104 are still valid tests. > Remove indefinite caching of key provider uri in DFSClient > ---------------------------------------------------------- > > Key: HDFS-11702 > URL: https://issues.apache.org/jira/browse/HDFS-11702 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Reporter: Rushabh S Shah > Assignee: Rushabh S Shah > Attachments: HDFS-11702.patch > > > There is an indefinite caching of key provider uri in dfsclient. > Relevant piece of code. > {code:title=DFSClient.java|borderStyle=solid} > /** > * The key provider uri is searched in the following order. > * 1. If there is a mapping in Credential's secrets map for namenode uri. > * 2. From namenode getServerDefaults rpc. > * 3. Finally fallback to local conf. > * @return keyProviderUri if found from either of above 3 cases, > * null otherwise > * @throws IOException > */ > URI getKeyProviderUri() throws IOException { > if (keyProviderUri != null) { > return keyProviderUri; > } > // Lookup the secret in credentials object for namenodeuri. > Credentials credentials = ugi.getCredentials(); > ... > ... > {code} > Once the key provider uri is set, it won't refresh the value even if the key > provider uri on namenode is changed. > For long running clients like on oozie servers, this means we have to bounce > all the oozie servers to get the change reflected. > After this change, the client will cache the value for an hour after which it > will issue getServerDefaults call and will refresh the key provider uri. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org