[
https://issues.apache.org/jira/browse/HDFS-13360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418504#comment-16418504
]
Nanda kumar edited comment on HDFS-13360 at 3/29/18 6:39 AM:
-------------------------------------------------------------
Thanks [~Deng FEI] for reporting and working on this.
We cannot start {{HdslDatanodeService}} (DatanodeStateMachine to be exact)
before starting {{ObjectStoreRestPlugin}} as we might miss setting
{{ozoneRestPort}} in some race condition. Please refer to
[this|https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16409726&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16409726]
comment for more details.
We should also create {{DatanodeDetails}} instance in {{HdslDatanodeService}}
before starting {{ObjectStoreRestPlugin}}, {{DatanodeDetails}} is shared
between {{HdslDatanodeService}} and {{ObjectStoreRestPlugin}}. This was the
main reason behind the movement of {{DatanodeDetails}} creation to the
constructor of {{HdslDatanodeService}}.
More details
[here|https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16413946&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16413946].
As you have mentioned the existing implementation breaks
MiniOzoneClassicCluster. We should think of a cleaner way to address this issue.
was (Author: nandakumar131):
Thanks [~Deng FEI] for reporting and working on this.
We cannot start {{HdslDatanodeService}} (DatanodeStateMachine to be exact)
before starting {{ObjectStoreRestPlugin}} as we might miss setting
{{ozoneRestPort}} in some race condition. Please refer to this comment for more
details.
We should also create {{DatanodeDetails}} instance in {{HdslDatanodeService}}
before starting {{ObjectStoreRestPlugin}}, {{DatanodeDetails}} is shared
between {{HdslDatanodeService}} and {{ObjectStoreRestPlugin}}. This was the
main reason behind the movement of {{DatanodeDetails}} creation to the
constructor of {{HdslDatanodeService}}.
More details here.
As you have mentioned the existing implementation breaks
MiniOzoneClassicCluster. We should think of a cleaner way to address this issue.
> Ozone: The configuration of implement of DataNodeServicePlugin should obtain
> from datanode instance
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-13360
> URL: https://issues.apache.org/jira/browse/HDFS-13360
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: DENG FEI
> Priority: Blocker
> Attachments: HDFS-13360-HDFS-7240.000.patch
>
>
> MiniOzoneClassicCluster configure Ozone is enable,but ObjectStoreRestPlugin &
> HdslDatanodeService load configuration from resouces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
