[
https://issues.apache.org/jira/browse/HDFS-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325409#comment-17325409
]
Xuze Yang edited comment on HDFS-15990 at 4/20/21, 1:30 AM:
------------------------------------------------------------
[~sodonnell] Thank you for your timely reply. I got it. Now I just think it may
cause a little confusion. Would code comments be a better choice？Anyway, this
is not a big problem.
I want to ask another question. In HDFS-7784 and HDFS-14617, they both aim to
load INodeSection and INodeDirectorySection in parallel. But their
implementation is a bit different. Take INodeSection for example, HDFS-7784
divide INodeSection into several INodeSection, while HDFS-14617 introduce
INodeSection_Sub. In practice, HDFS-14617 may encounter downgrade problems(see
HDFS-14771), but HDFS-7784 does not have this problem. So I want to ask why you
choose HDFS-14617 implementation. In another word, compare to HDFS-7784, what
are the advantages of HDFS-14617.
Looking forward to your answer, thanks!
was (Author: xuze yang):
[~sodonnell] Thank you for your timely reply. I got it. Now I just think it may
cause a lit confusion. Would code comments be a better choice？Anyway, this is
not a big problem.
I want to ask another question. In HDFS-7784 and HDFS-14617, they both aim to
load INodeSection and INodeDirectorySection in parallel. But their
implementation is a bit different. Take INodeSection for example, HDFS-7784
divide INodeSection into several INodeSection, while HDFS-14617 introduce
INodeSection_Sub. In practice, HDFS-14617 may encounter downgrade problems(see
HDFS-14771), but HDFS-7784 does not have this problem. So I want to ask why you
choose HDFS-14617 implementation. In another word, compare to HDFS-7784, what
are the advantages of HDFS-14617.
Looking forward to your answer, thanks!
> No need to write to sub_section when serialize SnapshotDiff Section
> -------------------------------------------------------------------
>
> Key: HDFS-15990
> URL: https://issues.apache.org/jira/browse/HDFS-15990
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 2.10.0
> Reporter: Xuze Yang
> Priority: Minor
>
> In FSImageFormatPBSnapshot.serializeSnapshotDiffSection(), the following code
> exists:
> {code:java}
> if (i % parent.getInodesPerSubSection() == 0) {
> parent.commitSubSection(headers,
> FSImageFormatProtobuf.SectionName.SNAPSHOT_DIFF_SUB);
> }{code}
> It aims to serialize SnapshotDiff information into several sub_sections(i.e.
> additional sub_sections information will be written to FileSummary Section).
> But in FSImageFormatPBSnapshot.loadSnapshotDiffSection(), it treats
> SnapshotDiffSection as a whole, rather than several sub_sections. So it's no
> need to introduce sub_sections here.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
