[ https://issues.apache.org/jira/browse/HDFS-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780635#comment-13780635 ]
Suresh Srinivas edited comment on HDFS-5272 at 9/30/13 6:10 PM: ---------------------------------------------------------------- Hi Jing, I can make the change too if you are busy. was (Author: arpitagarwal): Hi Jing, I can make the change too if you are busy. Thanks. -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You. > DFSUtil#getInfoServer cleanup > ----------------------------- > > Key: HDFS-5272 > URL: https://issues.apache.org/jira/browse/HDFS-5272 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.0.0 > Reporter: Arpit Agarwal > Assignee: Jing Zhao > > The {{httpsAddress}} parameter is not used outside of tests. > {code} > public static String getInfoServer(InetSocketAddress namenodeAddr, > Configuration conf, boolean httpsAddress) throws IOException { > boolean securityOn = UserGroupInformation.isSecurityEnabled(); > String httpAddressKey = (securityOn && httpsAddress) ? > DFS_NAMENODE_HTTPS_ADDRESS_KEY : DFS_NAMENODE_HTTP_ADDRESS_KEY; > String httpAddressDefault = (securityOn && httpsAddress) ? > DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT : > DFS_NAMENODE_HTTP_ADDRESS_DEFAULT; > {code} > [~jingzhao] confirmed on HDFS-5271 that DFS_NAMENODE_HTTP_ADDRESS_DEFAULT > will be the default that is always available so there should be no reason to > choose betwen DFS_NAMENODE_HTTP_ADDRESS_DEFAULT and > DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT. Filing Jira to clean this up. -- This message was sent by Atlassian JIRA (v6.1#6144)