[ 
https://issues.apache.org/jira/browse/HDFS-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225768#comment-14225768
 ] 

Haohui Mai edited comment on HDFS-7017 at 11/26/14 5:23 AM:
------------------------------------------------------------

{code}
virtual ~LeaseRenewer();
{code}

It no longer needs to have a virtual destructor since no class inherits 
{{LeaseRenewer}}.

Similar to the comments on {{LeaseRenewer}} and {{LeaseRenewerImpl}}, maybe the 
code can be further simplified by merging {{PipelineImpl}} into {{Pipeline}}.


was (Author: wheat9):
{code}
virtual ~LeaseRenewer();
{code}

It no longer needs to have a virtual destructor since no class inherits 
{{LeaseRenewer}}.

Similar to the comments on {{LeaseRenewer}} and {{LeaseRenewerImpl}}, maybe the 
code can be further simplified by merging {{PipelineImpl}} into {{Pipeline}},

> Implement OutputStream for libhdfs3
> -----------------------------------
>
>                 Key: HDFS-7017
>                 URL: https://issues.apache.org/jira/browse/HDFS-7017
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>            Assignee: Zhanwei Wang
>         Attachments: HDFS-7017-pnative.002.patch, 
> HDFS-7017-pnative.003.patch, HDFS-7017-pnative.004.patch, 
> HDFS-7017-pnative.005.patch, HDFS-7017.patch
>
>
> Implement pipeline and OutputStream C++ interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to