[
https://issues.apache.org/jira/browse/HDDS-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549948#comment-16549948
]
Xiaoyu Yao commented on HDDS-199:
---------------------------------
Thanks [~elek] for working on this. The patch looks good to me. I just have a
few comments below:
SCMEvents.java
Line 34-35: NIT: unused imports
SCMContainerPlacementRandom.java
Line 92-93: NIT: blank change.
SCMContainerPlacementCapacity.java
Line 100: can be removed as the super.chooseDatanodes() already removed the
excludedNodes?
ScmConfigKeys.java
Line 250: Update TestCommonConfigurationFields?
StorageContainerManager.java
Line 222: we need to ensure the LeaseManager instance
commandWatcherLeaseManager is shutdown upon SCM stop around line 585.
ReplicationCommandWatcher.java
Line 36: NIT: unused imports
ReplicationManager.java
Line 160: please update the title of the JIRA to reflect we handle under
replicated container only after this and open a separate Jira.
TestReplicationManager.java
Line 139: should we put it within try{} final{} to ensure the proper stop of
lease manger?
> Implement ReplicationManager to replicate Closed Containers
> -----------------------------------------------------------
>
> Key: HDDS-199
> URL: https://issues.apache.org/jira/browse/HDDS-199
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-199.001.patch, HDDS-199.002.patch,
> HDDS-199.003.patch, HDDS-199.004.patch, HDDS-199.005.patch,
> HDDS-199.006.patch, HDDS-199.007.patch, HDDS-199.008.patch,
> HDDS-199.009.patch, HDDS-199.010.patch, HDDS-199.011.patch
>
>
> HDDS/Ozone supports Open and Closed containers. In case of specific
> conditions (container is full, node is failed) the container will be closed
> and will be replicated in a different way. The replication of Open containers
> are handled with Ratis and PipelineManger.
> The ReplicationManager should handle the replication of the ClosedContainers.
> The replication information will be sent as an event
> (UnderReplicated/OverReplicated).
> The Replication manager will collect all of the events in a priority queue
> (to replicate first the containers where more replica is missing) calculate
> the destination datanode (first with a very simple algorithm, later with
> calculating scatter-width) and send the Copy/Delete container to the datanode
> (CommandQueue).
> A CopyCommandWatcher/DeleteCommandWatcher are also included to retry the
> copy/delete in case of failure. This is an in-memory structure (based on
> HDDS-195) which can requeue the underreplicated/overreplicated events to the
> prioirity queue unless the confirmation of the copy/delete command is arrived.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
