[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607871#comment-16607871
]
Anu Engineer commented on HDDS-403:
---
{quote}In HDDS-418, I see we are using the currentTime as the index.
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607870#comment-16607870
]
Hadoop QA commented on HDDS-403:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607857#comment-16607857
]
Xiaoyu Yao commented on HDDS-403:
-
Agree, for openKeyDeletionService, we will have a separate time field
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607834#comment-16607834
]
Anu Engineer commented on HDDS-403:
---
Please look at the patch 418, I am not convinced we can use
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607831#comment-16607831
]
Dinesh Chitlangia commented on HDDS-403:
Manual validation samples:
Volume:
{noformat}
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607796#comment-16607796
]
Anu Engineer commented on HDDS-403:
---
excellent resource on time.
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607787#comment-16607787
]
Xiaoyu Yao commented on HDDS-403:
-
{quote}The issue is that while creating the entities we use UTC but when
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607759#comment-16607759
]
Dinesh Chitlangia commented on HDDS-403:
[~anu] is there a difference between gmt and utc? Yes and
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607734#comment-16607734
]
Hadoop QA commented on HDDS-403:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607733#comment-16607733
]
Anu Engineer commented on HDDS-403:
---
I am sorry, I just check now and our friend google says "
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607663#comment-16607663
]
Xiaoyu Yao commented on HDDS-403:
-
[~anu], Time.now() should be fine here as we don't use it to calculate
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607657#comment-16607657
]
Anu Engineer commented on HDDS-403:
---
The change in KeyManageraImpl will introduce a subtle bug. We use
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607584#comment-16607584
]
Dinesh Chitlangia commented on HDDS-403:
[~xyao] - Thanks for your review.
Before this patch, in
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607551#comment-16607551
]
Xiaoyu Yao commented on HDDS-403:
-
Thanks [~dineshchitlangia] for reporting the issue and fix it. I think
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607447#comment-16607447
]
Hadoop QA commented on HDDS-403:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606892#comment-16606892
]
Hadoop QA commented on HDDS-403:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606790#comment-16606790
]
Dinesh Chitlangia commented on HDDS-403:
Verified on a cluster:
{{hadoop@8ca1824f010f:~$
17 matches
Mail list logo