[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668914#comment-16668914
]
Anu Engineer commented on HDDS-580:
---
bq. We should never ever ever support reformat
I can
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668895#comment-16668895
]
Arpit Agarwal commented on HDDS-580:
bq. We don't support format right now but it is co
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1666#comment-1666
]
Ajay Kumar commented on HDDS-580:
-
[~anu], [~arpitagarwal]
Even if init is idempotent there
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668082#comment-16668082
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667938#comment-16667938
]
Ajay Kumar commented on HDDS-580:
-
[~anu] thanks for offline discussion. Patch v11 moves co
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667816#comment-16667816
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667634#comment-16667634
]
Anu Engineer commented on HDDS-580:
---
bq. * Right now for a given component (SCM, OM, DN e
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667618#comment-16667618
]
Ajay Kumar commented on HDDS-580:
-
[~anu] thanks for detailed review.
{quote}I feel that t
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667615#comment-16667615
]
Arpit Agarwal commented on HDDS-580:
bq. Are we risk losing existing data when running
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667599#comment-16667599
]
Xiaoyu Yao commented on HDDS-580:
-
The current --init and --init-security are based on the
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667579#comment-16667579
]
Anu Engineer commented on HDDS-580:
---
It is, thanks for the correction. We probably should
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667565#comment-16667565
]
Arpit Agarwal commented on HDDS-580:
bq. {{--init}} should be idempotent already. Is it
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667553#comment-16667553
]
Anu Engineer commented on HDDS-580:
---
{quote}This is designed to handle the case where ozo
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667543#comment-16667543
]
Xiaoyu Yao commented on HDDS-580:
-
bq. Why do we have a command line called INIT_SECURITY s
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665846#comment-16665846
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665840#comment-16665840
]
Anu Engineer commented on HDDS-580:
---
[~ajayydv] Thanks for the updating the patch. A coup
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665751#comment-16665751
]
Ajay Kumar commented on HDDS-580:
-
patch v9 to move test case for rotating key pair to {{Te
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665648#comment-16665648
]
Ajay Kumar commented on HDDS-580:
-
[~xyao] thanks for review. Addressed all comments in pat
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664618#comment-16664618
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664461#comment-16664461
]
Xiaoyu Yao commented on HDDS-580:
-
Thanks [~ajayydv] for the update. Patch v7 looks very go
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664344#comment-16664344
]
Ajay Kumar commented on HDDS-580:
-
@patch v7 to satisfy false positive in findbug and \{{Se
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663437#comment-16663437
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662792#comment-16662792
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662622#comment-16662622
]
Ajay Kumar commented on HDDS-580:
-
Patch v5 with following changes:
* directory structure
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661140#comment-16661140
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660983#comment-16660983
]
Ajay Kumar commented on HDDS-580:
-
patch v4 to address checkstyle, findbug warnings and fai
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659994#comment-16659994
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659873#comment-16659873
]
Ajay Kumar commented on HDDS-580:
-
[~xyao] thanks for review.
{quote}SecurityUtil.java
Li
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655803#comment-16655803
]
Xiaoyu Yao commented on HDDS-580:
-
Thanks [~ajayydv] for working on this. Patch looks good
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647242#comment-16647242
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647020#comment-16647020
]
Ajay Kumar commented on HDDS-580:
-
patch v2 to fix checkstyle issues and delete the temp fi
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646162#comment-16646162
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645982#comment-16645982
]
Ajay Kumar commented on HDDS-580:
-
[~xyao] thanks for review. Addressed all comments in pat
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645731#comment-16645731
]
Xiaoyu Yao commented on HDDS-580:
-
Thanks [~ajayydv] for working on this. The patch looks g
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645352#comment-16645352
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645144#comment-16645144
]
Xiaoyu Yao commented on HDDS-580:
-
Same patch naming issue. I will upload a renamed the pat
[
https://issues.apache.org/jira/browse/HDDS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644659#comment-16644659
]
Hadoop QA commented on HDDS-580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
37 matches
Mail list logo