[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500962#comment-16500962 ] Bharat Viswanadham commented on HDDS-97: Thank You, [~xyao] and [~anu] for review. Committed to

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500943#comment-16500943 ] Xiaoyu Yao commented on HDDS-97: Thanks [~bharatviswa] for the update. The patch v4 LGTM, +1.  > Create

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495899#comment-16495899 ] genericqa commented on HDDS-97: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495814#comment-16495814 ] Bharat Viswanadham commented on HDDS-97: Hi [~xyao] Thanks for the review. Addressed review

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494194#comment-16494194 ] Xiaoyu Yao commented on HDDS-97: Thanks [~bharatviswa] for working on this. The latest patch looks good to

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494143#comment-16494143 ] genericqa commented on HDDS-97: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494022#comment-16494022 ] Bharat Viswanadham commented on HDDS-97: Hi [~anu] Thank You for the review. I have addressed your

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491330#comment-16491330 ] Anu Engineer commented on HDDS-97: -- [~bharatviswa] Thanks for updating the patch. It looks very good

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490292#comment-16490292 ] genericqa commented on HDDS-97: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490245#comment-16490245 ] Bharat Viswanadham commented on HDDS-97: Attached patch v02. Fixed test case failure and Jenkins 

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489819#comment-16489819 ] genericqa commented on HDDS-97: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489673#comment-16489673 ] Bharat Viswanadham commented on HDDS-97: [~arpitagarwal] Separated out the logic of versionFile to a

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487851#comment-16487851 ] genericqa commented on HDDS-97: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487764#comment-16487764 ] Anu Engineer commented on HDDS-97: -- +1, pending Jenkins. Please feel free to commit after Jenkins. Thanks

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487744#comment-16487744 ] Bharat Viswanadham commented on HDDS-97: submitting the patch now, as HDDS-48 is rebased to trunk. >

[jira] [Commented] (HDDS-97) Create Version File in Datanode

[ https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486575#comment-16486575 ] Bharat Viswanadham commented on HDDS-97: Attached the patch. HDDS-48 branch needs to be rebased, as