[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353977#comment-15353977
]
Kai Sasaki commented on HDFS-10534:
---
[~andrew.wang] Thanks for comment.
I think it is possible to
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352001#comment-15352001
]
Andrew Wang commented on HDFS-10534:
bq. This is also a metric that could be calculated in client-side
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348687#comment-15348687
]
Kai Sasaki commented on HDFS-10534:
---
Thank you so much [~andrew.wang] and [~zhz] for reviewing!
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348563#comment-15348563
]
Zhe Zhang commented on HDFS-10534:
--
Thanks Andrew. I just reverted the change.
bq. Why not present a
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348540#comment-15348540
]
Andrew Wang commented on HDFS-10534:
Adding a new metric is compatible, but upon looking at this
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348500#comment-15348500
]
Zhe Zhang commented on HDFS-10534:
--
Should this (adding a metric and adding it to web UI) be considered
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348493#comment-15348493
]
Hudson commented on HDFS-10534:
---
SUCCESS: Integrated in Hadoop-trunk-Commit #10016 (See
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347458#comment-15347458
]
Hadoop QA commented on HDFS-10534:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347028#comment-15347028
]
Zhe Zhang commented on HDFS-10534:
--
Thanks [~kaisasak] for the update! +1 on v5 patch after Jenkins.
>
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345386#comment-15345386
]
Zhe Zhang commented on HDFS-10534:
--
Thanks [~lewuathe]! Latest patch LGTM overall. A few minors:
# Can we
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343193#comment-15343193
]
Kai Sasaki commented on HDFS-10534:
---
[~zhz] Since several configurations in FSNamesystem are {{final}}
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343157#comment-15343157
]
Kai Sasaki commented on HDFS-10534:
---
Though checkstyle seems to be broken before attaching this patch,
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342084#comment-15342084
]
Hadoop QA commented on HDFS-10534:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338580#comment-15338580
]
Hadoop QA commented on HDFS-10534:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337348#comment-15337348
]
Kai Sasaki commented on HDFS-10534:
---
[~zhz] Thanks for checking! It sounds reasonable. I think we can
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337340#comment-15337340
]
Hadoop QA commented on HDFS-10534:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337269#comment-15337269
]
Zhe Zhang commented on HDFS-10534:
--
Thanks Kai! Patch looks pretty good. However I think we should make
[
https://issues.apache.org/jira/browse/HDFS-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333958#comment-15333958
]
Hadoop QA commented on HDFS-10534:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
18 matches
Mail list logo