[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422065#comment-15422065 ] Hadoop QA commented on HDFS-10549: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-15 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421982#comment-15421982 ] Xiao Chen commented on HDFS-10549: -- Thanks Yiqun for revving! Patch 5 looks good to me. +1 pending

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-15 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421954#comment-15421954 ] Yiqun Lin commented on HDFS-10549: -- Sorry, Xiao, I'm misread for that. {quote} I think we can remove the

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-15 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421257#comment-15421257 ] Xiao Chen commented on HDFS-10549: -- bq. Yes, it will be better to throw IOExceptions for

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420879#comment-15420879 ] Hadoop QA commented on HDFS-10549: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-15 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420815#comment-15420815 ] Yiqun Lin commented on HDFS-10549: -- Thanks a lot for the review, [~xiaochen]. {quote} I hope we can just

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-14 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420626#comment-15420626 ] Xiao Chen commented on HDFS-10549: -- Thanks [~linyiqun] for the patch, idea looks good. I noticed the

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-11 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417555#comment-15417555 ] Xiao Chen commented on HDFS-10549: -- bq. Can you help mark that jira? It seems that I am not allowed to do

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416733#comment-15416733 ] Hadoop QA commented on HDFS-10549: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-11 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416627#comment-15416627 ] Yiqun Lin commented on HDFS-10549: -- Thanks [~xiaochen] for the comments. Agree with your idea. Post the

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-10 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416265#comment-15416265 ] Xiao Chen commented on HDFS-10549: -- Thanks [~linyiqun] for working on this. Looking at your comment on

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413412#comment-15413412 ] Hadoop QA commented on HDFS-10549: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10549) Memory leak if exception happens when closing files being written

2016-08-09 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413397#comment-15413397 ] Yiqun Lin commented on HDFS-10549: -- I debug the test for {{TestCrcCorruption.testCorruptionDuringWrt}} in