[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447087#comment-15447087
]
Yongjun Zhang commented on HDFS-10625:
--
Committed to trunk, branch-2, branch-2.8
Thanks [~shahrs87]
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447083#comment-15447083
]
Hudson commented on HDFS-10625:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10368 (See
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446954#comment-15446954
]
Yongjun Zhang commented on HDFS-10625:
--
Sorry for the delay [~linyiqun]. I'm committing it shortly.
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417400#comment-15417400
]
Rushabh S Shah commented on HDFS-10625:
---
Both the failed tests:
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417402#comment-15417402
]
Rushabh S Shah commented on HDFS-10625:
---
[~yzhangal]/ [~vinayrpet]: can someone please commit the
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416554#comment-15416554
]
Vinayakumar B commented on HDFS-10625:
--
+1 for v5 patch.
checkstyle for method length can be
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416029#comment-15416029
]
Hadoop QA commented on HDFS-10625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415849#comment-15415849
]
Rushabh S Shah commented on HDFS-10625:
---
[~vinayrpet]: Can you please review the latest patch.
I
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405915#comment-15405915
]
Hadoop QA commented on HDFS-10625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405774#comment-15405774
]
Yiqun Lin commented on HDFS-10625:
--
Thanks a lot for the review, [~vinayrpet]. Post a new patch for
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405567#comment-15405567
]
Vinayakumar B commented on HDFS-10625:
--
one nit, I thought it was already mentioned.
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405522#comment-15405522
]
Yiqun Lin commented on HDFS-10625:
--
Thanks [~yzhangal] and [~shahrs87] for the review.
Hi, [~vinayrpet],
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399698#comment-15399698
]
Rushabh S Shah commented on HDFS-10625:
---
Thanks [~linyiqun] for updating the patch!
Thanks
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397819#comment-15397819
]
Yongjun Zhang commented on HDFS-10625:
--
Thanks [~vinayrpet] for the review and [~linyiqun] for the
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397263#comment-15397263
]
Hadoop QA commented on HDFS-10625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397133#comment-15397133
]
Vinayakumar B commented on HDFS-10625:
--
bq. One comment from me for this: Can we print the log
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396985#comment-15396985
]
Vinayakumar B commented on HDFS-10625:
--
bq. We can add a catch block here to catch the IOException
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396781#comment-15396781
]
Yiqun Lin commented on HDFS-10625:
--
Thanks [~yzhangal] for the comment. I will post a new patch for this
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396168#comment-15396168
]
Yongjun Zhang commented on HDFS-10625:
--
Hi [~linyiqun] and [~shahrs87],
Sorry for the delay. I took
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390271#comment-15390271
]
Yongjun Zhang commented on HDFS-10625:
--
Thanks [~linyiqun] for noticing that. sorry for being late on
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386985#comment-15386985
]
Yiqun Lin commented on HDFS-10625:
--
Hi, [~shahrs87], this jira is similar to HDFS-10626. Some codes are
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386477#comment-15386477
]
Rushabh S Shah commented on HDFS-10625:
---
[~yzhangal] [~jojochuang]: any further comments on the
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380048#comment-15380048
]
Hadoop QA commented on HDFS-10625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377247#comment-15377247
]
Yongjun Zhang commented on HDFS-10625:
--
Thanks [~shahrs87] for the patch and [~jojochuang] for the
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377228#comment-15377228
]
Wei-Chiu Chuang commented on HDFS-10625:
looks good to me.
VolumeScanner uses BlockSender and a
[
https://issues.apache.org/jira/browse/HDFS-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377192#comment-15377192
]
Hadoop QA commented on HDFS-10625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
26 matches
Mail list logo