[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563946#comment-15563946
]
Hadoop QA commented on HDFS-10972:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563538#comment-15563538
]
Mingliang Liu commented on HDFS-10972:
--
+1 pending on Jenkins.
> Add unit test for HDFS command
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563487#comment-15563487
]
Xiaobing Zhou commented on HDFS-10972:
--
branch-2.8 patch is posted [~liuml07] thanks.
> Add unit
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563164#comment-15563164
]
Hudson commented on HDFS-10972:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10578 (See
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563140#comment-15563140
]
Mingliang Liu commented on HDFS-10972:
--
Committed to {{trunk}} and {{branch-2}}. Can you provide a
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563086#comment-15563086
]
Mingliang Liu commented on HDFS-10972:
--
Test failures are not related.
> Add unit test for HDFS
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563084#comment-15563084
]
Mingliang Liu commented on HDFS-10972:
--
+1 Will commit shortly.
> Add unit test for HDFS command
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561349#comment-15561349
]
Hadoop QA commented on HDFS-10972:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561183#comment-15561183
]
Xiaobing Zhou commented on HDFS-10972:
--
v003 addressed your most recent comments, thanks [~liuml07]
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556929#comment-15556929
]
Hadoop QA commented on HDFS-10972:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556745#comment-15556745
]
Mingliang Liu commented on HDFS-10972:
--
# We don't have to call {{restoreStream()}} in
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556648#comment-15556648
]
Xiaobing Zhou commented on HDFS-10972:
--
v002 added test for run on exception.
> Add unit test for
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1885#comment-1885
]
Mingliang Liu commented on HDFS-10972:
--
Can you add a failing case (e.g. no arguments provided) for
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1808#comment-1808
]
Hadoop QA commented on HDFS-10972:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1596#comment-1596
]
Xiaobing Zhou commented on HDFS-10972:
--
HDFS-10981 is filed to refactor DFSAdmin by removing print
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1577#comment-1577
]
Xiaobing Zhou commented on HDFS-10972:
--
Thank you [~liuml07] for reviews. patch v001 fixed them.
>
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553474#comment-15553474
]
Hadoop QA commented on HDFS-10972:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553439#comment-15553439
]
Mingliang Liu commented on HDFS-10972:
--
I found most of my comments can be addressed if you refer the
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553388#comment-15553388
]
Mingliang Liu commented on HDFS-10972:
--
Thanks for the patch. I think this UT is useful. I'll confirm
[
https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553234#comment-15553234
]
Xiaobing Zhou commented on HDFS-10972:
--
v000 is posted for reviews, thanks.
> Add unit test for HDFS
20 matches
Mail list logo