[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645693#comment-15645693 ] Eric Badger commented on HDFS-11048: Using URI escaping wouldn't be great because it w

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645607#comment-15645607 ] Allen Wittenauer commented on HDFS-11048: - It's a pretty standard practice to esca

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645579#comment-15645579 ] Eric Badger commented on HDFS-11048: What do you propose to fix that? Changing the sin

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645558#comment-15645558 ] Allen Wittenauer commented on HDFS-11048: - bq. I can think of one pretty contrive

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645543#comment-15645543 ] Eric Badger commented on HDFS-11048: bq. e.g., does '\thisfile' begin with a tab or do

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645480#comment-15645480 ] Allen Wittenauer commented on HDFS-11048: - OK, that's what I thought. We probably

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645455#comment-15645455 ] Eric Badger commented on HDFS-11048: Oops, never actually answered your question. An i

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645452#comment-15645452 ] Eric Badger commented on HDFS-11048: All backslashes in the input will be printed in t

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645429#comment-15645429 ] Allen Wittenauer commented on HDFS-11048: - So in the log it will be "\\" or "\"?

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645403#comment-15645403 ] Eric Badger commented on HDFS-11048: bq. What happens if the filename has a backslash

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-11-07 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645163#comment-15645163 ] Allen Wittenauer commented on HDFS-11048: - What happens if the filename has a back

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-28 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616361#comment-15616361 ] Eric Badger commented on HDFS-11048: Thanks [~liuml07], [~aw], [~daryn]! > Audit Log

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616154#comment-15616154 ] Hudson commented on HDFS-11048: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-27 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612711#comment-15612711 ] Allen Wittenauer commented on HDFS-11048: - IMHO, even though it's incompatible, it

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612710#comment-15612710 ] Mingliang Liu commented on HDFS-11048: -- This makes sense to me. Just want to open the

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-27 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612692#comment-15612692 ] Daryn Sharp commented on HDFS-11048: >From a purist perspective, it's "incompatible".

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-27 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612617#comment-15612617 ] Mingliang Liu commented on HDFS-11048: -- +1 Will commit this in 24 hours if no more co

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612339#comment-15612339 ] Hadoop QA commented on HDFS-11048: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-26 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609704#comment-15609704 ] Mingliang Liu commented on HDFS-11048: -- +1 for the proposal. {code} 1141 public

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-26 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609422#comment-15609422 ] Allen Wittenauer commented on HDFS-11048: - Marking this as an incompatible change,

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-25 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605441#comment-15605441 ] Eric Badger commented on HDFS-11048: The 2 test failures are unrelated to this patch a

[jira] [Commented] (HDFS-11048) Audit Log should escape control characters

2016-10-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603360#comment-15603360 ] Hadoop QA commented on HDFS-11048: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote