[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138478#comment-16138478
]
Vinayakumar B commented on HDFS-11738:
--
pushed to branch-2 and branch-2.8 as well after resolving
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135910#comment-16135910
]
Hudson commented on HDFS-11738:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12220 (See
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134194#comment-16134194
]
John Zhuge commented on HDFS-11738:
---
Plan to commit tomorrow if no objection. Will take care of the typo
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133488#comment-16133488
]
Hadoop QA commented on HDFS-11738:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133467#comment-16133467
]
John Zhuge commented on HDFS-11738:
---
+1 LGTM pending pre-commit tests.
Still typo: "no nodes to
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131867#comment-16131867
]
John Zhuge commented on HDFS-11738:
---
The patch looks great! Only a few minor comments:
* Keep the old
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130007#comment-16130007
]
John Zhuge commented on HDFS-11738:
---
Ok, will do before tomorrow noon.
> Hedged pread takes more time
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130005#comment-16130005
]
Vinayakumar B commented on HDFS-11738:
--
Thanks [~jojochuang].
[~jzhuge], do you want to take a look
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128334#comment-16128334
]
Wei-Chiu Chuang commented on HDFS-11738:
Thanks, the latest patch looks really good to me.
On a
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128285#comment-16128285
]
Vinayakumar B commented on HDFS-11738:
--
Test failure is unrelated.
checkstyle is about line length,
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127755#comment-16127755
]
Hadoop QA commented on HDFS-11738:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127631#comment-16127631
]
Vinayakumar B commented on HDFS-11738:
--
Thanks [~jojochuang] for reviewing changes.
bq. IIUC, the
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127273#comment-16127273
]
Wei-Chiu Chuang commented on HDFS-11738:
Hello [~vinayrpet] thanks for the patch!
I reviewed the
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126184#comment-16126184
]
Hadoop QA commented on HDFS-11738:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124428#comment-16124428
]
John Zhuge commented on HDFS-11738:
---
[~vinayrpet] Committed HDFS-11303.
> Hedged pread takes more time
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122889#comment-16122889
]
John Zhuge commented on HDFS-11738:
---
[~zhangchen] is the original author. [~jojochuang] and I just tried
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122878#comment-16122878
]
Vinayakumar B commented on HDFS-11738:
--
I see that, Following changes in
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122848#comment-16122848
]
Wei-Chiu Chuang commented on HDFS-11738:
Thanks [~vinayrpet] for the patch! I haven't reviewed the
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070116#comment-16070116
]
Hadoop QA commented on HDFS-11738:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010399#comment-16010399
]
Vinayakumar B commented on HDFS-11738:
--
Hi [~cnauroth]/[~andrew.wang]/[~jingzhao]
Can anyone review
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996062#comment-15996062
]
Vinayakumar B commented on HDFS-11738:
--
Hi [~zhz],
Can you please take a look at this?
> hedged
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994270#comment-15994270
]
Vinayakumar B commented on HDFS-11738:
--
Test failures and findbugs are unrelated.
> hedged pread
[
https://issues.apache.org/jira/browse/HDFS-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992851#comment-15992851
]
Hadoop QA commented on HDFS-11738:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
23 matches
Mail list logo
