[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2018-04-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450802#comment-16450802 ] Hudson commented on HDFS-11832: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028160#comment-16028160 ] Hudson commented on HDFS-11832: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11795 (See

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-29 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028137#comment-16028137 ] Akira Ajisaka commented on HDFS-11832: -- +1, checking this in. > Switch leftover logs to slf4j format

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-26 Thread Hui Xu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025863#comment-16025863 ] Hui Xu commented on HDFS-11832: --- Hi Akira Ajisaka, Would you please review the v005 patch again? It's based

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024505#comment-16024505 ] Hadoop QA commented on HDFS-11832: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-25 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024344#comment-16024344 ] Akira Ajisaka commented on HDFS-11832: -- The patch mostly looks good to me. I'm thinking we can remove

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-24 Thread Hui Xu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024124#comment-16024124 ] Hui Xu commented on HDFS-11832: --- Hi, I want to know what to do next? Just waiting some member to merge the

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-19 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017734#comment-16017734 ] Chen Liang commented on HDFS-11832: --- Seems our comments interleaved, did not see your comments when I

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-19 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017724#comment-16017724 ] Chen Liang commented on HDFS-11832: --- Thanks [~10075197] for the followup. But just similar to

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-19 Thread Hui Xu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017719#comment-16017719 ] Hui Xu commented on HDFS-11832: --- Aha, I think you are correct. :-) And in three or more arguments case, e.g:

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-19 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017669#comment-16017669 ] Akira Ajisaka commented on HDFS-11832: -- Thanks [~10075197], I think this is not right. In the

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-19 Thread Hui Xu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017598#comment-16017598 ] Hui Xu commented on HDFS-11832: --- Hi Akira Ajisaka and Chen Liang, Would you refer to the official link as

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016340#comment-16016340 ] Hadoop QA commented on HDFS-11832: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-18 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016080#comment-16016080 ] Akira Ajisaka commented on HDFS-11832: -- Some source code still need {{if(LOG.isDebugEnabled())}}. For

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015183#comment-16015183 ] Hadoop QA commented on HDFS-11832: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-17 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014683#comment-16014683 ] Chen Liang commented on HDFS-11832: --- Thanks [~10075197] for updating the patch! I tested v002 patch

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013550#comment-16013550 ] Hadoop QA commented on HDFS-11832: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-16 Thread Hui Xu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013499#comment-16013499 ] Hui Xu commented on HDFS-11832: --- Hi, slf4j need not such boiler-plate code as: if (LOG.isDebugEnabled()) {

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-16 Thread Hui Xu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013454#comment-16013454 ] Hui Xu commented on HDFS-11832: --- Thank Chen Liang for providing the patch timely. Just I found there are

[jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java

2017-05-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013136#comment-16013136 ] Hadoop QA commented on HDFS-11832: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||