[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-06-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500287#comment-16500287 ] Hudson commented on HDFS-13155: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-06-03 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499574#comment-16499574 ] Wei-Chiu Chuang commented on HDFS-13155: +1 > BlockPlacementPolicyDefault.choose

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-06-03 Thread Zsolt Venczel (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499547#comment-16499547 ] Zsolt Venczel commented on HDFS-13155: -- Unit test failures are passing locally with

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-06-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499231#comment-16499231 ] genericqa commented on HDFS-13155: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-06-02 Thread Zsolt Venczel (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499188#comment-16499188 ] Zsolt Venczel commented on HDFS-13155: -- Thanks [~gabor.bota] and [~jojochuang] for t

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-06-01 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498330#comment-16498330 ] Wei-Chiu Chuang commented on HDFS-13155: The fix looks good to me. Regarding read

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-05-29 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493657#comment-16493657 ] Gabor Bota commented on HDFS-13155: --- [~zvenczel] You are right with those points, and I

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-05-29 Thread Zsolt Venczel (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493574#comment-16493574 ] Zsolt Venczel commented on HDFS-13155: -- Thank you [~gabor.bota] for your review. My

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-05-29 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493485#comment-16493485 ] Gabor Bota commented on HDFS-13155: --- Thanks for the patch [~zvenczel]! I think using a

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-05-15 Thread Zsolt Venczel (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475407#comment-16475407 ] Zsolt Venczel commented on HDFS-13155: -- Failed unit tests seem to be unrelated. The

[jira] [Commented] (HDFS-13155) BlockPlacementPolicyDefault.chooseTargetInOrder Not Checking Return Value for NULL

2018-05-14 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474695#comment-16474695 ] genericqa commented on HDFS-13155: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote