[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490524#comment-16490524
]
Ewan Higgs commented on HDFS-13186:
---
005
* MultipartUploader$complete returns a PathHan
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490690#comment-16490690
]
genericqa commented on HDFS-13186:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502249#comment-16502249
]
Chris Douglas commented on HDFS-13186:
--
Only a few minor points:
* {{LocalFileSystem
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503281#comment-16503281
]
Ewan Higgs commented on HDFS-13186:
---
006
* Address asflicense issues
* Address checks
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503283#comment-16503283
]
Ewan Higgs commented on HDFS-13186:
---
007
* Forgot to add org.apache.hadoop.fs.s3a.S3AM
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503434#comment-16503434
]
genericqa commented on HDFS-13186:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503518#comment-16503518
]
genericqa commented on HDFS-13186:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508610#comment-16508610
]
Chris Douglas commented on HDFS-13186:
--
bq. Does the contract test for the local FS
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508961#comment-16508961
]
genericqa commented on HDFS-13186:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512472#comment-16512472
]
Ewan Higgs commented on HDFS-13186:
---
[~chris.douglas]'s patch looked good to me.
00
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513321#comment-16513321
]
genericqa commented on HDFS-13186:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449420#comment-16449420
]
Chris Douglas commented on HDFS-13186:
--
I like this design. The {{MultiPartUploader}}
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456519#comment-16456519
]
Ewan Higgs commented on HDFS-13186:
---
[~chris.douglas], thanks for the feedback.
{quote}T
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458530#comment-16458530
]
Ewan Higgs commented on HDFS-13186:
---
004
- MPU learns abort.
- FS MPU::complete forces o
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458648#comment-16458648
]
genericqa commented on HDFS-13186:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461912#comment-16461912
]
Chris Douglas commented on HDFS-13186:
--
Thanks for the updated patch. Minor comments
16 matches
Mail list logo