[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-14 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399925#comment-16399925 ] Bharat Viswanadham commented on HDFS-13239: --- Thank You [~xiaochen] and [~hanisha

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397289#comment-16397289 ] Hudson commented on HDFS-13239: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-13 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397273#comment-16397273 ] Xiao Chen commented on HDFS-13239: -- +1, committing this > Fix non-empty dir warning mess

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396338#comment-16396338 ] genericqa commented on HDFS-13239: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-12 Thread Hanisha Koneru (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396320#comment-16396320 ] Hanisha Koneru commented on HDFS-13239: --- +1 pending Jenkins. > Fix non-empty dir wa

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-12 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396200#comment-16396200 ] Bharat Viswanadham commented on HDFS-13239: --- Attached patch v04 to fix checkstyl

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-10 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394388#comment-16394388 ] Xiao Chen commented on HDFS-13239: -- +1 pending checkstyle. Will let this float for a few

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394126#comment-16394126 ] genericqa commented on HDFS-13239: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-09 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394073#comment-16394073 ] Bharat Viswanadham commented on HDFS-13239: --- [~xiaochen] Addressed review comme

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-09 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394033#comment-16394033 ] Xiao Chen commented on HDFS-13239: -- Thanks for revving [~bharatviswa]. A minor comment:

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392661#comment-16392661 ] genericqa commented on HDFS-13239: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392502#comment-16392502 ] Bharat Viswanadham commented on HDFS-13239: --- [~xiaochen] Updated patch v02, to

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392482#comment-16392482 ] Bharat Viswanadham commented on HDFS-13239: --- Yes, [~xiaochen]  patch proposed so

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392472#comment-16392472 ] Xiao Chen commented on HDFS-13239: -- As the property name suggests, that is an NN configur

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392449#comment-16392449 ] Bharat Viswanadham commented on HDFS-13239: --- Hi [~xiaochen] If you see the upda

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392355#comment-16392355 ] Xiao Chen commented on HDFS-13239: -- If you look into the code, null is handled at: {code:

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392270#comment-16392270 ] genericqa commented on HDFS-13239: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392175#comment-16392175 ] Bharat Viswanadham commented on HDFS-13239: --- Hi [~xiaochen] As we are reading t

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392142#comment-16392142 ] Xiao Chen commented on HDFS-13239: -- Thanks [~hanishakoneru] for reporting the issue and [

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Hanisha Koneru (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392096#comment-16392096 ] Hanisha Koneru commented on HDFS-13239: --- Thanks [~bharatviswa]. +1 for patch v01 pe

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392071#comment-16392071 ] Bharat Viswanadham commented on HDFS-13239: --- [~hanishakoneru] Thanks for the rev

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Hanisha Koneru (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391816#comment-16391816 ] Hanisha Koneru commented on HDFS-13239: --- Thanks [~bharatviswa]. Got it now. Can we

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391751#comment-16391751 ] Bharat Viswanadham commented on HDFS-13239: --- Hi [~hanishakoneru] I have thought

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-08 Thread Hanisha Koneru (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391730#comment-16391730 ] Hanisha Koneru commented on HDFS-13239: --- Thanks for working on this, [~bharatviswa].

[jira] [Commented] (HDFS-13239) Fix non-empty dir warning message when setting default EC policy

2018-03-07 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390561#comment-16390561 ] genericqa commented on HDFS-13239: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote