[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871598#comment-16871598
]
Hudson commented on HDFS-13358:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16813 (See
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767672#comment-16767672
]
CR Hota commented on HDFS-13358:
[~elgoiri] [~brahmareddy] [~surendrasingh]
Thanks again for all the
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767661#comment-16767661
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767588#comment-16767588
]
Íñigo Goiri commented on HDFS-13358:
Well... Yetus came back before I finished to write the comment.
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767586#comment-16767586
]
Íñigo Goiri commented on HDFS-13358:
Thanks [~crh] for the fixes.
+1 on
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767585#comment-16767585
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767485#comment-16767485
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767488#comment-16767488
]
CR Hota commented on HDFS-13358:
[~elgoiri] Thanks for the review.
Reflection part of code now tries to
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767433#comment-16767433
]
Íñigo Goiri commented on HDFS-13358:
I'm running the unit tests and I found a couple things.
In
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767087#comment-16767087
]
Surendra Singh Lilhore commented on HDFS-13358:
---
+1 LGTM
> RBF: Support for Delegation
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767070#comment-16767070
]
Brahma Reddy Battula commented on HDFS-13358:
-
{quote}Could you please help me understand the
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766634#comment-16766634
]
CR Hota commented on HDFS-13358:
[~brahmareddy] Gentle ping !
[~surendrasingh] Could you please help
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765513#comment-16765513
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765410#comment-16765410
]
Íñigo Goiri commented on HDFS-13358:
Just a minor comment: instead of assertTrue for ==, we should
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764017#comment-16764017
]
Íñigo Goiri commented on HDFS-13358:
Thanks [~crh] for [^HDFS-13358-HDFS-13891.007.patch].
I would
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763970#comment-16763970
]
CR Hota commented on HDFS-13358:
[~elgoiri] The HDFS-13358-HDFS-13891.007.patch patch has all changes
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763946#comment-16763946
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762237#comment-16762237
]
CR Hota commented on HDFS-13358:
[~elgoiri] Thanks for the review. Will take care of latest comments in
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762067#comment-16762067
]
Íñigo Goiri commented on HDFS-13358:
Thanks [~crh] for [^HDFS-13358-HDFS-13891.006.patch]; this is
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762044#comment-16762044
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755343#comment-16755343
]
Brahma Reddy Battula commented on HDFS-13358:
-
[~crh] thanks for updating the patch.
* can
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754368#comment-16754368
]
Íñigo Goiri commented on HDFS-13358:
Thanks [~crh] for the clarification on the contract.
I think we
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754258#comment-16754258
]
CR Hota commented on HDFS-13358:
I had taken a look at the contracts part before writing
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754221#comment-16754221
]
Íñigo Goiri commented on HDFS-13358:
This just goes to the {{SecurityManager}} directly.
I'm
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754204#comment-16754204
]
CR Hota commented on HDFS-13358:
[~elgoiri] Thanks for the review. There is already unit test added in
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754184#comment-16754184
]
Íñigo Goiri commented on HDFS-13358:
Thanks [~crh] for [^HDFS-13358-HDFS-13891.005.patch].
I think
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753716#comment-16753716
]
CR Hota commented on HDFS-13358:
[~elgoiri] [~surendrasingh] [~brahmareddy] Thanks for all the reviews so
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752969#comment-16752969
]
Hadoop QA commented on HDFS-13358:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752845#comment-16752845
]
Hadoop QA commented on HDFS-13358:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724368#comment-16724368
]
Íñigo Goiri commented on HDFS-13358:
I'm seeing an issue with the unit tests though.
Most tests run
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723214#comment-16723214
]
Íñigo Goiri commented on HDFS-13358:
Yes, tested with multiple Routers and it works.
However, this
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722857#comment-16722857
]
Surendra Singh Lilhore commented on HDFS-13358:
---
Thanks [~crh] for working on this jira.
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722679#comment-16722679
]
CR Hota commented on HDFS-13358:
[~brahmareddy] Thanks for reviewing. The znodes will be specific to
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703669#comment-16703669
]
Brahma Reddy Battula commented on HDFS-13358:
-
[~crh] Thanks for working on this.
At first
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684322#comment-16684322
]
Hadoop QA commented on HDFS-13358:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681777#comment-16681777
]
Íñigo Goiri commented on HDFS-13358:
Yes, getDelegationTokens() doesn't look very useful and goes
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680765#comment-16680765
]
Hadoop QA commented on HDFS-13358:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680580#comment-16680580
]
CR Hota commented on HDFS-13358:
Many thanks [~elgoiri] for your initial inputs.
Could you help me the
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680554#comment-16680554
]
Hadoop QA commented on HDFS-13358:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680521#comment-16680521
]
Íñigo Goiri commented on HDFS-13358:
I've internally tested [^HDFS-13358-HDFS-13891.001.patch] in our
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680416#comment-16680416
]
CR Hota commented on HDFS-13358:
[~brahmareddy] Thanks for the follow-up. I am able to get a patch
[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680148#comment-16680148
]
Brahma Reddy Battula commented on HDFS-13358:
-
[~crh] any update on this..?
> RBF: Support
42 matches
Mail list logo